Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

math/rand/v2 #782

Merged
merged 5 commits into from
Jul 17, 2024
Merged

math/rand/v2 #782

merged 5 commits into from
Jul 17, 2024

Conversation

Hueter57
Copy link
Contributor

@Hueter57 Hueter57 commented Jul 5, 2024

close #736

@Hueter57 Hueter57 requested a review from H1rono July 5, 2024 09:17
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 25.85%. Comparing base (d680332) to head (b507575).
Report is 8 commits behind head on v2.

Files Patch % Lines
router/auth.go 0.00% 7 Missing ⚠️
testutil/random/ramdom.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #782      +/-   ##
==========================================
- Coverage   25.85%   25.85%   -0.01%     
==========================================
  Files         148      148              
  Lines       26979    26976       -3     
==========================================
- Hits         6976     6974       -2     
+ Misses      19126    19125       -1     
  Partials      877      877              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

testutil/random/ramdom.go Outdated Show resolved Hide resolved
testutil/random/ramdom.go Outdated Show resolved Hide resolved
testutil/random/ramdom.go Outdated Show resolved Hide resolved
H1rono
H1rono previously approved these changes Jul 6, 2024
Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
他にmath/rand使ってるところなければマージしてください

@Hueter57
Copy link
Contributor Author

Hueter57 commented Jul 6, 2024

探したらmath/randを使っているところがもう一か所ありました
こっちも直してみます

Jomon/router/auth.go

Lines 129 to 133 in ef91d11

var randSrcPool = sync.Pool{
New: func() interface{} {
return rand.NewSource(time.Now().UnixNano())
},
}

@H1rono H1rono dismissed their stale review July 6, 2024 08:08

まだあった

@Hueter57 Hueter57 requested a review from H1rono July 17, 2024 02:06
Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とりあえずこれだけ

router/auth.go Outdated Show resolved Hide resolved
@Hueter57 Hueter57 requested a review from H1rono July 17, 2024 12:51
Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@H1rono H1rono merged commit 5c20e25 into v2 Jul 17, 2024
6 of 7 checks passed
@H1rono H1rono deleted the math_rand_v2_update branch July 17, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

math/rand/v2
2 participants