WebhookServiceの構造体定義+NewServerで読み込みを行うようにした #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #814 +/- ##
==========================================
- Coverage 25.26% 25.24% -0.02%
==========================================
Files 147 147
Lines 30583 30737 +154
==========================================
+ Hits 7726 7761 +35
- Misses 21980 22090 +110
- Partials 877 886 +9 ☔ View full report in Codecov by Sentry. |
H1rono
requested changes
Dec 6, 2024
router/router.go
Outdated
Comment on lines
25
to
30
| type WebHookService struct { | ||
| webhookSecret string; | ||
| webhookChannelId string; | ||
| webhookId string; | ||
|
|
||
| } |
There was a problem hiding this comment.
構造体の概形はあってます 👍
ただ、フィールドが小文字始まりになってしまっているのでserviceパッケージ側からアクセスできません...
加えて、このPRではservice/webhook.goにあるWebhookEventHandlerとRequestWebhookを、ただの関数から作成した構造体のメソッドに置き換えることを目標としたいです。
// before
func WebhookEventHandler(...)
func RequestWebhook(...) error
// after
func (s WebHookService) WebhookEventHandler(...)
func (s WebHookService) RequestWebhook(...) errorので、構造体の定義はrouter側ではなくservice側に置いて欲しいです。NewWebhookServiceのような関数をservice/webhook.goに生やして、router側ではこの関数を使ってWebhookServiceを作成すると丸そうだなと思ってます。 🙏
There was a problem hiding this comment.
(あと細かいですが、WebHookではなくWebhookに揃えて欲しいです)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebhookServiceの構造体定義+NewServerで読み込みを行うようにした