Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] form周りの改善(valibotの使用, contextの利用) #938

Merged
merged 53 commits into from
Aug 24, 2024
Merged

[dashboard] form周りの改善(valibotの使用, contextの利用) #938

merged 53 commits into from
Aug 24, 2024

Conversation

eyemono-moe
Copy link
Contributor

@eyemono-moe eyemono-moe commented Jul 22, 2024 •
edited
Loading

なぜやるか

fix #902, fix #899

「modular formsのコンポーネントで自動生成される formのstore制御用のonInput, onChange, onBlur」と、独自のform制御
(kobalteのradio groupでbooleanが値として使えないから文字列↔booleanの変換を挟んだり, ビルドタイプの設定のために"runtime"/"static"と"buildpack"/"cmd"/"docker"の2*3のradio groupの入力値を組み合わせて"runtimeCmd"に変換したりしてる部分とか)がかみ合っていないために複数バグが存在していた。(#902, #899)
#902 (comment)

やったこと

やらなかったこと

  • 既存のコンポーネントのディレクトリ整理

資料

@github-actions GitHub Actions
Copy link

Preview (prod backend + PR dashboard) → https://938.ns-preview.trapti.tech/

@eyemono-moe eyemono-moe changed the title Fix/use-valibot [dashboard] form周りの改善(valibotの使用, contextの利用) Jul 22, 2024
@eyemono-moe eyemono-moe mentioned this pull request Jul 27, 2024
Closed
@motoki317 motoki317 linked an issue Aug 12, 2024 that may be closed by this pull request
削除されたブランチだとフィールドが空で表示される #827
Closed
@eyemono-moe eyemono-moe marked this pull request as ready for review August 23, 2024 13:25
motoki317
motoki317 reviewed Aug 23, 2024
View reviewed changes
dashboard/package.json Outdated Show resolved Hide resolved
@cp-20
Copy link
Contributor

cp-20 commented Aug 24, 2024

(まだ中身見てなくてdescription読んだだけなんですが) #827 が修正されてるなら fix #827 もしておくと良さそうです？

@eyemono-moe
remove unnecessary comments
3b4bd0e 
handlerをpropsで受け取ることで使いまわせるようにしようと思っていたが、使いまわされる予定が無さそう
cp-20
cp-20 approved these changes Aug 24, 2024
View reviewed changes
Copy link
Contributor

@cp-20 cp-20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全体的には良さそうに見えます👍　ありがとうございます！

細かいところをいくつか書いたんですが、どれもmustではないので適当に対応してもらえるとGoodです

dashboard/src/features/application/components/form/BuildConfigForm.tsx Outdated Show resolved Hide resolved
dashboard/src/features/application/schema/applicationSchema.ts Outdated Show resolved Hide resolved
dashboard/src/features/application/schema/applicationSchema.ts Outdated Show resolved Hide resolved
dashboard/src/features/application/schema/envVarSchema.ts Show resolved Hide resolved
dashboard/src/features/application/schema/applicationConfigSchema.ts Outdated Show resolved Hide resolved
dashboard/src/features/repository/schema/repositorySchema.ts Show resolved Hide resolved
@eyemono-moe
remove unused import
71dbec3
@eyemono-moe
chore: matchで改行が多くなっていたので1行にまとめた
479d1fd
@eyemono-moe
chore: simplify transform return value
652cca2
@eyemono-moe
refactor: replace initialValues func name
c5201db 
createApplicationFormInitialValues -> getInitialValueOfCreateAppForm
updateApplicationFormInitialValues -> getInitialValueOfUpdateAppForm
createRepositoryFormInitialValues -> getInitialValueOfCreateRepoForm
updateRepositoryFormInitialValues -> getInitialValueOfUpdateRepoForm
@eyemono-moe
refactor: ts-patternのexhaustiveが使える箇所では使うように
9364326
@eyemono-moe
test: add envVars test
34ee384
@eyemono-moe
Merge branch 'main' into fix/use-valibot
c328c07
@eyemono-moe eyemono-moe merged commit 7b7de61 into main Aug 24, 2024
19 checks passed
@eyemono-moe eyemono-moe deleted the fix/use-valibot branch August 24, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@motoki317 motoki317 motoki317 left review comments

@cp-20 cp-20 cp-20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@eyemono-moe @cp-20 @motoki317