fix: delete runtime images before deleting application #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod backend + PR dashboard) → https://960.ns-preview.trapti.tech/ |
motoki317
reviewed
Sep 2, 2024
motoki317
approved these changes
Sep 2, 2024
| @@ -102,6 +102,7 @@ type ArtifactRepository interface { | |||
|
|
|||
| type RuntimeImageRepository interface { | |||
| CreateRuntimeImage(ctx context.Context, image *RuntimeImage) error | |||
| DeleteRuntimeImagesByAppID(ctx context.Context, appId string) error | |||
There was a problem hiding this comment.
[nits] RuntimeImageに関する操作なのは、型名と、メソッドを呼び出すときにも runtimeRepo.Delete... とか呼び出すことからわかるので、メソッド名にRuntimeImageとあるのは少し冗長かもしれないです
気になったら程度で良いですが
There was a problem hiding this comment.
これは自分も少し思ったのですが、他の repository の命名と合わせて 'RuntimeImages' も入れておきました
https://github.com/traPtitech/NeoShowcase/blob/main/pkg/domain/repository.go
もし DeleteByAppIDとするなら他も全部変えちゃいたいですが、そこまでするほどでもないかな、と思うので今はこのままにしておこうと思います
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
なぜやるか
fix #959
アプリの削除をする際、外部キーで紐づいているデータを削除しなければならないが、
runtime_imagesから削除する処理が抜けていたため、アプリを削除できないようになっていたやったこと
アプリ削除の前に紐づいているデータを削除する
やらなかったこと
資料