⬆️ bump the gomod-deps group with 8 updates #528
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps the gomod-deps group with 8 updates: | Package | From | To | | --- | --- | --- | | [github.com/arran4/golang-ical](https://github.com/arran4/golang-ical) | `0.2.1` | `0.2.6` | | [github.com/jszwec/csvutil](https://github.com/jszwec/csvutil) | `1.8.0` | `1.10.0` | | [github.com/labstack/echo/v4](https://github.com/labstack/echo) | `4.11.3` | `4.11.4` | | [go.uber.org/zap](https://github.com/uber-go/zap) | `1.26.0` | `1.27.0` | | [golang.org/x/oauth2](https://github.com/golang/oauth2) | `0.15.0` | `0.17.0` | | [google.golang.org/api](https://github.com/googleapis/google-api-go-client) | `0.152.0` | `0.167.0` | | [gorm.io/driver/mysql](https://github.com/go-gorm/mysql) | `1.5.2` | `1.5.4` | | [gorm.io/gorm](https://github.com/go-gorm/gorm) | `1.25.5` | `1.25.7-0.20240204074919-46816ad31dde` | Updates `github.com/arran4/golang-ical` from 0.2.1 to 0.2.6 - [Release notes](https://github.com/arran4/golang-ical/releases) - [Commits](arran4/golang-ical@v0.2.1...v0.2.6) Updates `github.com/jszwec/csvutil` from 1.8.0 to 1.10.0 - [Release notes](https://github.com/jszwec/csvutil/releases) - [Commits](jszwec/csvutil@v1.8.0...v1.10.0) Updates `github.com/labstack/echo/v4` from 4.11.3 to 4.11.4 - [Release notes](https://github.com/labstack/echo/releases) - [Changelog](https://github.com/labstack/echo/blob/master/CHANGELOG.md) - [Commits](labstack/echo@v4.11.3...v4.11.4) Updates `go.uber.org/zap` from 1.26.0 to 1.27.0 - [Release notes](https://github.com/uber-go/zap/releases) - [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md) - [Commits](uber-go/zap@v1.26.0...v1.27.0) Updates `golang.org/x/oauth2` from 0.15.0 to 0.17.0 - [Commits](golang/oauth2@v0.15.0...v0.17.0) Updates `google.golang.org/api` from 0.152.0 to 0.167.0 - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.152.0...v0.167.0) Updates `gorm.io/driver/mysql` from 1.5.2 to 1.5.4 - [Commits](go-gorm/mysql@v1.5.2...v1.5.4) Updates `gorm.io/gorm` from 1.25.5 to 1.25.7-0.20240204074919-46816ad31dde - [Release notes](https://github.com/go-gorm/gorm/releases) - [Commits](https://github.com/go-gorm/gorm/commits) --- updated-dependencies: - dependency-name: github.com/arran4/golang-ical dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod-deps - dependency-name: github.com/jszwec/csvutil dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod-deps - dependency-name: github.com/labstack/echo/v4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod-deps - dependency-name: go.uber.org/zap dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod-deps - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod-deps - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod-deps - dependency-name: gorm.io/driver/mysql dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod-deps - dependency-name: gorm.io/gorm dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod-deps ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
|
| std.ComponentBase.AddProperty(ics.ComponentProperty(ics.PropertyTzoffsetfrom), "+0900") | ||
| std.ComponentBase.AddProperty(ics.ComponentProperty(ics.PropertyTzoffsetto), "+0900") | ||
| std.ComponentBase.AddProperty(ics.ComponentProperty(ics.PropertyTzname), "JST") | ||
| std.ComponentBase.AddProperty(ics.ComponentProperty(ics.PropertyDtstart), "19700101T000000") | ||
| tz.Components = append(tz.Components, &std) | ||
| cal.Components = append(cal.Components, &tz) | ||
| cal.AddVTimezone(tz) |
There was a problem hiding this comment.
arran4/golang-ical@14095cc#diff-414491c8e37212605f612587cf5cb5dbf1711eef4b733970d280b57f4e1011ceR710
これよく見つけましたね
やってることはcal.AddTimezone("Asia/Tokyo")と同じなのでそっちのがよさそう
他のComponentPropertyはAddPropertyで渡してるのが気になるのでそこらへんの行消しても問題ないか確認して欲しいです！
There was a problem hiding this comment.
AddTimezone("Asia/Tokyo")だと出力が以下のようになってしまって
BEGIN:VTIMEZONE
TZID:Asia/Tokyo
END:VTIMEZONE
これはiCalのRFCのTime Zone Componentに関する以下の記述の「"STANDARD"か"DAYLIGHT"サブコンポーネントを少なくとも一つは含なければならない」に反するので良くなさそうです．(Macのカレンダーアプリ上での挙動に変化は見られませんでしたが...)
https://tex2e.github.io/rfc-translater/html/rfc5545.html#3-6-5--Time-Zone-Component
The "VTIMEZONE" calendar component MUST include the "TZID" property and at least one definition of a "STANDARD" or "DAYLIGHT" sub-component. The "STANDARD" or "DAYLIGHT" sub-component MUST include the "DTSTART", "TZOFFSETFROM", and "TZOFFSETTO" properties.
There was a problem hiding this comment.
STANDARDサブコンポーネントのDTSTARTプロパティに関してはSetStartAt関数が用意されていました．
https://github.com/arran4/golang-ical/blob/0fcebed54126830e648865ec05e459ad213986df/components.go#L119
AddPropertyから直そうとすると以下のようになりそうで少し煩雑な気がしますがどうするのが正解でしょうか...
// Time Zone の使用が始まる日時
stdStartDateTimeString := "19700101T000000"
// stdStartDateTimeString の フォーマット (arran4/golang-ical内の定数を参考にした)
icalTimestampFormatLocal := "20060102T150405"
stdStartDateTime, _ := time.Parse(icalTimestampFormatLocal, stdStartDateTimeString)
std.SetStartAt(stdStartDateTime)There was a problem hiding this comment.
正直あんまりよくわかってないんですが
std.ComponentBase.AddProperty(ics.ComponentProperty(ics.PropertyTzoffsetfrom), "+0900")
std.ComponentBase.AddProperty(ics.ComponentProperty(ics.PropertyTzoffsetto), "+0900")
std.ComponentBase.AddProperty(ics.ComponentProperty(ics.PropertyTzname), "JST")の部分は現状でも消してよいということですか？
AddPropertyから直そうとすると以下のようになりそうで少し煩雑な気がしますがどうするのが正解でしょうか...
stdStartDateTimeString := "19700101T000000"はunix時間の開始時刻なのでtime.Unix(0, 0)を使えば良さそう？
https://pkg.go.dev/time#Unix
There was a problem hiding this comment.
申し訳ありません...
RFC見てたら以下のような記述があって
The collection of properties that are used to define the "STANDARD" and "DAYLIGHT" sub-components include:
The mandatory "DTSTART" property gives the effective onset date and local time for the time zone sub-component definition. "DTSTART" in this usage MUST be specified as a date with a local time value.
STANDARDサブコンポーネントのDTSTARTはローカルタイムゾーンじゃないといけなくて
SetStartAtは内部でUTCに直してるのでここでの使用は不適切でした．https://github.com/arran4/golang-ical/blob/0fcebed54126830e648865ec05e459ad213986df/components.go#L120
なので，最終的には以下のような形になりそうです．
(DTSTART用のComponentProperty型の値は用意されてたのでそっちに変更しました)
func ICalFormat(events []*domain.Event, host string, userMap map[uuid.UUID]*domain.User) *ics.Calendar {
var std ics.Standard
std.ComponentBase.AddProperty(ics.ComponentProperty(ics.PropertyTzoffsetfrom), "+0900")
std.ComponentBase.AddProperty(ics.ComponentProperty(ics.PropertyTzoffsetto), "+0900")
std.ComponentBase.AddProperty(ics.ComponentProperty(ics.PropertyTzname), "JST")
// ics.ComponentProperty(ics.PropertyDtstart) -> ics.ComponentPropertyDtStart
std.ComponentBase.AddProperty(ics.ComponentPropertyDtStart, "19700101T000000")
tz := ics.NewTimezone("Asia/Tokyo")
tz.Components = append(tz.Components, &std)
cal := ics.NewCalendar()
cal.AddVTimezone(tz)
for _, e := range events {
vevent := iCalVeventFormat(e, host, userMap)
cal.AddVEvent(vevent)
}
return cal
}
|
|
|
Looks like these dependencies are updatable in another way, so this is no longer needed. |
Bumps the gomod-deps group with 8 updates:
0.2.10.2.61.8.01.10.04.11.34.11.41.26.01.27.00.15.00.17.00.152.00.167.01.5.21.5.41.25.51.25.7-0.20240204074919-46816ad31ddeUpdates
github.com/arran4/golang-icalfrom 0.2.1 to 0.2.6Release notes
Sourced from github.com/arran4/golang-ical's releases.
Commits
0fcebedMerge pull request #87 from JM-Lemmi/fix/text_escapingbb39d64Revert "fix: only escape property values when serializing."7bd8708test: Add test for escaped semicolons in RRULEs542d6e5Merge pull request #86 from JM-Lemmi/fix/text_escaping647cf9etest: Add test for escaped semicolons in property parameters0f8a325fix: reorder string replaces in escaping values.3ffa099fix: only escape property values when serializing.51fa6f1Merge pull request #85 from brackendawson/panic46e2a5cExclude fuzz testing from pre-1.18 toolchainsa8f0586fix panic when param value has incomplete escape sequenceUpdates
github.com/jszwec/csvutilfrom 1.8.0 to 1.10.0Release notes
Sourced from github.com/jszwec/csvutil's releases.
Commits
53deda7feat: allow struct slice and struct array for valueType (#70)4c3b8e6feat: add AlignRecord flag to Decoder5633865chore: update github workflow to use Go1.2105adbbbAdd package name when usingNewDecoderfunction (#61)Updates
github.com/labstack/echo/v4from 4.11.3 to 4.11.4Release notes
Sourced from github.com/labstack/echo/v4's releases.
Changelog
Sourced from github.com/labstack/echo/v4's changelog.
Commits
226e4f0Changelog for v4.11.4 (#2564)209c6a1Update deps and mark Go version to 1.18 as this is what golang.org/x/* use. (...287a82cUpgrade golang.org/x/crypto to v0.17.0 to fix vulnerability issue (#2562)584cb85request logger: add example for Slog https://pkg.go.dev/log/slog (#2543)Updates
go.uber.org/zapfrom 1.26.0 to 1.27.0Release notes
Sourced from go.uber.org/zap's releases.
Changelog
Sourced from go.uber.org/zap's changelog.
Commits
fcf8ee5Release v1.27.0 (#1419)e5a56eeAdd WithPanicHook logger option for panic log tests (#1416)0e2aa4eassets: Fix logo color profile (#1418)956a21cAdd methods for logging with level as argument (#1406)2a893f6build(deps): bump golangci/golangci-lint-action from 3 to 4 (#1417)e5745d6ci: Test with Go 1.22 (#1409)7db06bczapslog: rename Option to HandlerOption (#1411)35ded09zapslog: fix all with slogtest, support inline group, ignore empty group. (#1...27b96e3Make zaptest.NewTestingWriter public (#1399)70f61bbzapslog: Bump zap from v1.24.0 to v1.26.0 (#1404)Updates
golang.org/x/oauth2from 0.15.0 to 0.17.0Commits
ebe81adgo.mod: update golang.org/x dependenciesadffd94google/internal/externalaccount: update serviceAccountImpersonationRE to supp...deefa7egoogle/downscope: add DownscopingConfig.UniverseDomain to support TPC39adbb7go.mod: update golang.org/x dependencies4ce7bbbgoogle: add Credentials.GetUniverseDomain with GCE MDS support1e6999bgoogle: add UniverseDomain to CredentialsParamsUpdates
google.golang.org/apifrom 0.152.0 to 0.167.0Release notes
Sourced from google.golang.org/api's releases.
... (truncated)
Changelog
Sourced from google.golang.org/api's changelog.
... (truncated)
Commits
548436bchore(main): release 0.167.0 (#2428)55a9e5afeat(all): auto-regenerate discovery clients (#2429)f72b5affeat(all): auto-regenerate discovery clients (#2427)133e58bchore(main): release 0.166.0 (#2418)446a6bdfeat(all): auto-regenerate discovery clients (#2426)b7d596bchore(all): update all (#2423)124a535feat(all): auto-regenerate discovery clients (#2425)b3f9c38feat(all): auto-regenerate discovery clients (#2424)af6aa38feat(all): auto-regenerate discovery clients (#2421)762eb61feat(all): auto-regenerate discovery clients (#2420)Updates
gorm.io/driver/mysqlfrom 1.5.2 to 1.5.4Commits
b87f024fix: migrator for mysql 5.6 (#141)e05761brefactor: distinguish between Unique and UniqueIndex (#123)7cfeac9ci: update go testing versions (#140)a6570f0fix: tidb error log (#136)Updates
gorm.io/gormfrom 1.25.5 to 1.25.7-0.20240204074919-46816ad31ddeCommits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions