lokiのログをS3に保存するように #633
Merged
lokiのログをS3に保存するように #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cp-20
requested changes
Dec 12, 2024
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: my-secret |
There was a problem hiding this comment.
ここの名前を s3-credentials にしてほしいです！ (単純に書き換えるのではなく、一旦復号化してから書き換える必要がある)
|
変更して、保存先を変える日を1日遅らせました |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerではテストしましたが、k8sではテストしていません。
あと、ruleはローカルに保存する設定になっているので、ruleが設定されていたらPVCを消すにあたって作業が必要になりそうです。（s3に保存することもできるが、ruleが設定されていたら移行が必要）
個人的には、PVCこのままでもログデータは消えていくはずなのでそれでいいのかなと思っています。