Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

設定画面のセッションタブの改修 #4155

Merged
merged 16 commits into from
Feb 5, 2024

Conversation

SSlime-s
Copy link
Member

@SSlime-s SSlime-s commented Nov 17, 2023

元issue #2203

image

Figma: https://www.figma.com/file/6Wme6N24y3GN2jD0vqZWZr/traQ-S-UI?type=design&node-id=9741-24242&mode=dev

動作確認

アクセスを許可しているアプリ の欄は (:tabun:) 本番環境でないと中身が入った状態を見れない
手元で試す場合は ./dev.config.tsexport const DEV_SERVER_PROXY_HOST = 'https://q.trap.jp' に書き換えて、本番環境を指すようにする

@SSlime-s SSlime-s self-assigned this Nov 17, 2023
Copy link

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6647db2) 86.35% compared to head (5758e92) 86.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4155   +/-   ##
=======================================
  Coverage   86.35%   86.36%           
=======================================
  Files          66       66           
  Lines        4719     4722    +3     
  Branches      564      565    +1     
=======================================
+ Hits         4075     4078    +3     
  Misses        638      638           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ISO 形式で日付のみを返す関数を追加
@SSlime-s SSlime-s force-pushed the SSlime/imp-settings-session-tab branch from d7bc98c to 1a3d3a5 Compare November 17, 2023 12:56
Copy link
Contributor

@mehm8128 mehm8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
いくつか:pray:

src/components/Settings/SessionTab/ViewStates.vue Outdated Show resolved Hide resolved
src/components/Settings/SessionTab/ViewStates.vue Outdated Show resolved Hide resolved
src/views/Settings/SessionTab.vue Outdated Show resolved Hide resolved
src/components/Settings/SessionTab/TokenInfo.vue Outdated Show resolved Hide resolved
src/components/Settings/SessionTab/TokenInfo.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@mehm8128 mehm8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません1つ追加で:pray:

Copy link
Contributor

@mehm8128 mehm8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです:kansya_kansya:

@mehm8128
Copy link
Contributor

mehm8128 commented Feb 5, 2024

マージ権限ないの忘れてたのでマージします

@mehm8128 mehm8128 merged commit 4f0340c into master Feb 5, 2024
11 checks passed
@mehm8128 mehm8128 deleted the SSlime/imp-settings-session-tab branch February 5, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants