Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ファイルモーダルが画面中央に表示されるように修正した #4169

Closed
wants to merge 7 commits into from

Conversation

Nattuki
Copy link
Contributor

@Nattuki Nattuki commented Nov 27, 2023

close #3970

@Nattuki Nattuki self-assigned this Nov 27, 2023
Copy link

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea4d834) 86.35% compared to head (231f5da) 86.35%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4169   +/-   ##
=======================================
  Coverage   86.35%   86.35%           
=======================================
  Files          66       66           
  Lines        4719     4719           
  Branches      564      564           
=======================================
  Hits         4075     4075           
  Misses        638      638           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mehm8128
Copy link
Contributor

PRありがとうございます!
設定画面改修のブランチからそのまま変更しているようなので、ここからbaseブランチを設定画面改修のブランチにしておいてもらえると、files changedの画面が見やすくなって助かります:pray:
_20231128_081146

@Nattuki Nattuki changed the base branch from master to Natsuki/theme-alter November 30, 2023 12:52
@mehm8128
Copy link
Contributor

あー途中で別のをmasterにマージしたから微妙におかしくなってそう
一旦このまま見ます

@mehm8128
Copy link
Contributor

mehm8128 commented Dec 2, 2023

中身はよさそうなのですが、Natsuki/theme-alterブランチから生やしてるとそっちマージするまでこっちもマージできなくてやっぱりよくなさそうなので、masterブランチから生やしてもう1回PR作ってほしいです:pray:

@Nattuki Nattuki closed this Dec 4, 2023
@Nattuki Nattuki deleted the Natsuki/issue3970 branch December 4, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ファイルモーダルが画面上端に表示される
3 participants