Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

サブビューを実装 #4467

Merged
merged 2 commits into from
Jan 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/Main/MainView/ChannelView/ChannelView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
:pinned-messages="pinnedMessages"
:typing-users="typingUsers"
/>
<!-- <SubQallView /> -->
</template>
<template #sidebar>
<channel-sidebar
Expand Down
4 changes: 3 additions & 1 deletion src/components/Main/MainView/QallView/AudioTrack.vue
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ onMounted(() => {
})

onUnmounted(() => {
trackInfo.trackPublication?.track?.detach()
if (audioElement.value) {
trackInfo.trackPublication?.track?.detach(audioElement.value)
}
})
</script>

Expand Down
13 changes: 7 additions & 6 deletions src/components/Main/MainView/QallView/QallView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import CallControlButton from './CallControlButton.vue'
import CallControlButtonSmall from './CallControlButtonSmall.vue'
import ScreenShareComponent from './ScreenShareComponent.vue'
import { LocalTrackPublication } from 'livekit-client'

const {
tracksMap,
Expand Down Expand Up @@ -58,7 +59,7 @@
}
}
} catch (err) {
console.error('Failed to toggle audio:', err)

Check warning on line 62 in src/components/Main/MainView/QallView/QallView.vue

View workflow job for this annotation

GitHub Actions / run lint

Unexpected console statement
}
}

Expand All @@ -71,6 +72,7 @@
for (const trackInfo of tracksMap.value.values()) {
if (
!trackInfo.isRemote &&
trackInfo.trackPublication instanceof LocalTrackPublication &&
trackInfo.trackPublication?.kind === 'video' &&
!trackInfo.trackPublication.trackName?.includes('screen')
) {
Expand All @@ -84,7 +86,7 @@
? '/@/assets/icons/videocam.svg?url'
: '/@/assets/icons/videocam_off.svg?url'
} catch (err) {
console.error('Failed to toggle video:', err)

Check warning on line 89 in src/components/Main/MainView/QallView/QallView.vue

View workflow job for this annotation

GitHub Actions / run lint

Unexpected console statement
}
}

Expand All @@ -97,6 +99,7 @@
for (const trackInfo of tracksMap.value.values()) {
if (
!trackInfo.isRemote &&
trackInfo.trackPublication instanceof LocalTrackPublication &&
trackInfo.trackPublication?.kind === 'video' &&
trackInfo.trackPublication.trackName?.includes('screen')
) {
Expand All @@ -110,21 +113,21 @@
? '/@/assets/icons/stop_screen_share.svg?url'
: '/@/assets/icons/screen_share.svg?url'
} catch (err) {
console.error('Failed to toggle screen sharing:', err)

Check warning on line 116 in src/components/Main/MainView/QallView/QallView.vue

View workflow job for this annotation

GitHub Actions / run lint

Unexpected console statement
}
}

const handleSound = () => {
// TODO
console.log('sound')

Check warning on line 122 in src/components/Main/MainView/QallView/QallView.vue

View workflow job for this annotation

GitHub Actions / run lint

Unexpected console statement
}
const handleReaction = () => {
// TODO
console.log('reaction')

Check warning on line 126 in src/components/Main/MainView/QallView/QallView.vue

View workflow job for this annotation

GitHub Actions / run lint

Unexpected console statement
}
const handleGroup = () => {
// TODO
console.log('group')

Check warning on line 130 in src/components/Main/MainView/QallView/QallView.vue

View workflow job for this annotation

GitHub Actions / run lint

Unexpected console statement
}

const videoInputs = ref<MediaDeviceInfo[]>([])
Expand Down Expand Up @@ -188,17 +191,13 @@
</button>

<div :class="$style.TrackContainer">
<template
v-for="([sid, track], index) in tracksMap.entries()"
:key="index"
>
<template v-for="[sid, track] in tracksMap.entries()" :key="sid">
<VideoComponent
v-if="
track.trackPublication?.kind === 'video' &&
!screenShareTrackSidMap.has(sid)
"
:track-info="track"
:participant-identity="track.participantIdentity"
:class="$style.video"
/>
<ScreenShareComponent
Expand All @@ -214,7 +213,9 @@
v-else-if="
track.trackPublication?.kind === 'audio' &&
track.isRemote &&
!screenShareTrackSidMap.values().some(valueSid => valueSid === sid)
!screenShareTrackSidMap
.values()
?.some?.(valueSid => valueSid === sid)
"
:track-info="track"
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,10 @@ onMounted(() => {
})

onUnmounted(() => {
trackInfo.trackPublication?.track?.detach()
audioTrackInfo?.trackPublication?.track?.detach()
if (videoElement.value && audioElement.value) {
trackInfo.trackPublication?.track?.detach(videoElement.value)
audioTrackInfo?.trackPublication?.track?.detach(audioElement.value)
}
})
</script>

Expand Down
29 changes: 29 additions & 0 deletions src/components/Main/MainView/QallView/SubQallView.vue
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<script lang="ts" setup>
import { computed } from 'vue'
import AudioTrack from './AudioTrack.vue'
import VideoTrack from './VideoTrack.vue'
import { useQall } from '/@/composables/qall/useQall'

const { tracksMap } = useQall()

const firstVideoTrack = computed(
() =>
tracksMap.value &&
Array.from(tracksMap.value.entries()).find(
([_sid, track]) => track.trackPublication?.kind === 'video'
)
)
</script>
<template>
<VideoTrack
v-if="firstVideoTrack"
:key="firstVideoTrack[0]"
:track-info="firstVideoTrack[1]"
/>
<template v-for="[sid, track] in tracksMap.entries()" :key="sid">
<audio-track
v-if="track.trackPublication?.kind === 'audio'"
:track-info="track"
/>
</template>
</template>
11 changes: 6 additions & 5 deletions src/components/Main/MainView/QallView/VideoTrack.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ import { onMounted, onUnmounted, ref, useTemplateRef, watchEffect } from 'vue'
import { useQall } from '/@/composables/qall/useQall'
import type { TrackInfo } from '/@/composables/qall/useLiveKitSDK'

const { trackInfo, participantIdentity } = defineProps<{
const { trackInfo } = defineProps<{
trackInfo: TrackInfo
participantIdentity: string
}>()

const { removeVideoTrack } = useQall()
Expand All @@ -25,14 +24,16 @@ onMounted(() => {
})

onUnmounted(() => {
trackInfo.trackPublication?.track?.detach()
if (videoElement.value) {
trackInfo.trackPublication?.track?.detach(videoElement.value)
}
})
</script>

<template>
<div :id="'camera-' + participantIdentity">
<div :id="'camera-' + trackInfo.participantIdentity">
<div>
<p>{{ participantIdentity }}</p>
<p>{{ trackInfo.participantIdentity }}</p>
</div>
<video
v-if="trackInfo.trackPublication"
Expand Down
2 changes: 1 addition & 1 deletion src/components/Main/NavigationBar/DesktopNavigationBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
/>
<transition name="fade-bottom">
<ephemeral-navigation-content
v-if="ephemeralNavigationSelectorState.currentNavigation"
v-if="true"
:class="$style.ephemeralNavigation"
:current-ephemeral-navigation="
ephemeralNavigationSelectorState.currentNavigation
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
<ephemeral-navigation-content-container :transparent="transparent">
<transition name="fade-bottom" mode="out-in">
<qall-controller v-if="currentEphemeralNavigation === 'qallController'" />
<draft-list v-else-if="currentEphemeralNavigation === 'draftList'" />
<SubQallView v-else-if="currentEphemeralNavigation === 'draftList'" />

<!-- <draft-list v-else-if="currentEphemeralNavigation === 'draftList'" /> -->
<audio-controller
v-else-if="currentEphemeralNavigation === 'audioController'"
/>
Expand All @@ -13,9 +15,10 @@
<script lang="ts" setup>
import EphemeralNavigationContentContainer from './EphemeralNavigationContentContainer.vue'
import QallController from './QallController/QallController.vue'
import DraftList from './DraftList/DraftList.vue'

Check warning on line 18 in src/components/Main/NavigationBar/EphemeralNavigationContent/EphemeralNavigationContent.vue

View workflow job for this annotation

GitHub Actions / run lint

'DraftList' is defined but never used
import AudioController from './AudioController/AudioController.vue'
import type { EphemeralNavigationItemType } from '/@/components/Main/NavigationBar/composables/useNavigationConstructor'
import SubQallView from '../../MainView/QallView/SubQallView.vue'

withDefaults(
defineProps<{
Expand Down
8 changes: 4 additions & 4 deletions src/composables/qall/useLiveKitSDK.ts
Original file line number Diff line number Diff line change
Expand Up @@ -367,10 +367,10 @@ const addScreenShareTrack = async () => {
[videoSid]: audioSid
}
screenShareTrackSidMap.value.set(videoSid, audioSid)
await room.value.localParticipant.setAttributes({
...room.value.localParticipant.attributes,
[videoSid]: audioSid
})
// await room.value.localParticipant.setAttributes({
// ...room.value.localParticipant.attributes,
// [videoSid]: audioSid
// })
}
} catch {
// TODO:シェアをキャンセルした時も失敗しましたメッセージがでるのはちょっと違和感があるかも
Expand Down
Loading