Add inclusive/exclusive sum and prod #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+385
to
+387
| let const_val = input.expand.as_const().unwrap(); | ||
| let var = Variable::constant(const_val.cast_to(Out::as_elem(scope))); | ||
| ExpandElement::Plain(var).into() |
There was a problem hiding this comment.
Nice fix! Forcing the constant is the right move here.
There was a problem hiding this comment.
It was causing issues because I implemented the IntExpand dynamic element, and that was causing this code to emit i64 constants in WGPU (which isn't supported).
nathanielsimard
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds plane inclusive/exclusive sum and prod.
Testing
Adds new tests for the new ops.