Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matmul quantized test metadata #481

Merged
merged 5 commits into from
Feb 17, 2025
Merged

Conversation

maxtremblay
Copy link
Collaborator

I write a new section for the quantized matmul in the book. This will be used as reference for the implementation. I also added support for matmul metadata to the testing suite.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice detailed explanation! 🙂

I have some minor comments, mostly over form more than content.

Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me apart from superficial comments

we introduce different algorithms provided by CubeCL.
This is a best effort list and we focus first on non-trivial algorithms
deserving more explanations than what is reasonable to put in the API documentation.
This section is also a bit more technical compared to the others as it serve two purposes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serves

Comment on lines +110 to +111
For example, if \\(\sigma = 0.3\\), then \\(f = -1\\) as \\(2^{-1} = 0.5 > 0.3 \\)
and \\(2^{-2} = 0.25 < 0.3\\).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is confusing

}
```
Of course,
in CubeCL, we stride to provide the fastest implementation for GPU devices.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we stride? 😄

@maxtremblay maxtremblay merged commit 716f4d0 into main Feb 17, 2025
5 checks passed
@maxtremblay maxtremblay deleted the matmul-quantized-test-metadata branch February 17, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants