-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Barrier variant + memcpy_async benchmarks + Matmul with barrier #497
base: main
Are you sure you want to change the base?
Conversation
|
||
#[cube] | ||
impl<MP: MatmulPrecision, SMM, LL, RL> GlobalMatmul<MP> | ||
for SimpleBarrierDummyMatmul<MP, SMM, LL, RL> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's the same as the SimpleBarrierMatmul, I would simply make it generic on the copy mechanism instead of forking the first one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually tried making it generic in my subsequent upcoming PR, but it turned out to be a pain. In the end I deleted the dummy one, it's not that useful.
Barrier variant
memcpy_async benchmarks
Matmul with barrier