Merge pull request #852 from creative-commoners/pulls/8/protect-hooks-2

API Set extension hook implementation visibility to protected
tractorcow-farm · May 21, 2024 · 80a09b0 · 80a09b0
2 parents ae72395 + 27fd72e
commit 80a09b0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/docs/en/dataobjects.md b/docs/en/dataobjects.md
@@ -78,7 +78,7 @@ use TractorCow\Fluent\Extension\FluentExtension;
 
 class PlayerExtension extends FluentExtension
 {
-    public function updateCMSFields(FieldList $fields)
+    protected function updateCMSFields(FieldList $fields)
     {
         $fields->removeByName('SomeIrrelevantField');
         parent::updateCMSFields($fields);

diff --git a/docs/en/scenarios.md b/docs/en/scenarios.md
@@ -128,7 +128,7 @@ class SiteTreeFluentExtension extends SiteTreeExtension
      * @param SQLSelect $query
      * @param DataQuery|null $dataQuery
      */
-    public function augmentSQL(SQLSelect $query, DataQuery $dataQuery = null)
+    protected function augmentSQL(SQLSelect $query, DataQuery $dataQuery = null)
     {
         // We only want to apply this logic on the frontend.
         if (!FluentState::singleton()->getIsFrontend()) {

diff --git a/src/Extension/FluentReadVersionsExtension.php b/src/Extension/FluentReadVersionsExtension.php
@@ -22,7 +22,7 @@ class FluentReadVersionsExtension extends Extension
      *
      * @param DataList &$list
      */
-    public function updateList(DataList &$list)
+    protected function updateList(DataList &$list)
     {
         /** @var DataObject $singleton */
         $singleton = Injector::inst()->get($list->dataClass());