Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG Fix compatibility issues with mysql 5.7 and above (fluent 4) #618

Open
wants to merge 1 commit into
base: 4.4
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions _config.php
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
<?php

use SilverStripe\Dev\Deprecation;
use SilverStripe\ORM\DB;

Deprecation::notification_version('4.0.0', 'tractorcow/silverstripe-fluent');

// Credit to https://github.com/sunnysideup thank you for the mysql fix
DB::query("SET SESSION sql_mode='REAL_AS_FLOAT,PIPES_AS_CONCAT,ANSI_QUOTES,IGNORE_SPACE';");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same problem as #617

Need to conditional and apply only to mysql, not postgres / sqlite etc...