skip empty 'where' clauses #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tractorcow
approved these changes
Apr 13, 2023
|
Odd that that predicate was empty in the first place. We have suppressed the symptom; Is there worth looking into a deeper cause? |
|
Hey uh, I appreciate the merge but I really needed it for SS4, not SS5... any chance it can be applied to your 6.0 branch too? |
|
a quick debug shows that the $query->getWhere(); line is returning an empty condition at index 0. This suggests to me that the problem is outside this component. |
MLindenhofer
added a commit
to MLindenhofer/silverstripe-fluent
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for both symbiote/silverstripe-gridfieldextensions#356 and possibly #257