MNT Run module-standardiser #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Don't merge yet - I'll make the changes to satisfy the new PHPStan linting rule. |
|
I like the phpstan inclusion. |
|
Check your invites added you as maintainer |
GuySartorelli
force-pushed
the
pulls/7/module-standardiser-1706667883
branch
from
20849c0 to
ebf89ad
Compare
|
There we go, that should go green now.
Yeah we're slowly getting into some more robust code standards. For now we're only applying a single custom PHPstan rule, but it opens the door to progressively having stricter standards.
Awesome, thank you! 💙 |
emteknetnz
approved these changes
Feb 2, 2024
|
Approved by a core committer, so self-merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request was created automatically by module-standardiser