Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dev/task to initialise DataObjects for existing datasets #835

Conversation

nathanbrauer
Copy link
Contributor

New task is based on the original task built for SiteTree but is now extendable for any DataObject enabled with Fluent. To prevent duplicate code, the original task now extends the new task.

Included updated documentation

cc: @muskie9

@tractorcow
Copy link
Collaborator

Looks good but you have some linting issues to fix.

FILE: ...-fluent/silverstripe-fluent/src/Task/InitialDataObjectLocalisationTask.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 284 | ERROR | [x] The closing brace for the class must go on the next line
     |       |     after the body
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...stripe-fluent/silverstripe-fluent/src/Task/InitialPageLocalisationTask.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 48 | ERROR | [x] The closing brace for the class must go on the next line
    |       |     after the body
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Copy link
Collaborator

@tractorcow tractorcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented

New task is based on the original task built for SiteTree but is now extendable for any DataObject enabled with Fluent. To prevent duplicate code, the original task now extends the new task.
@nathanbrauer nathanbrauer force-pushed the feature/initial-task-for-dataobjects branch from 7d9f500 to 07328cf Compare April 2, 2024 20:22
@nathanbrauer
Copy link
Contributor Author

Just pushed the linting changes. I also discovered the minimum php for this branch is ^7.1, so I made a few adjustments to prevent fatal errors.

@tractorcow tractorcow merged commit acb1466 into tractorcow-farm:6 Apr 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants