WIP: build multiplier only using vcpkg #510
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frabert
force-pushed
the
frabert/build-using-vcpkg
branch
from
6e41240 to
1e223da
Compare
pgoodman
reviewed
Jan 28, 2024
CMakeLists.txt
Outdated
| @@ -25,7 +25,7 @@ endif() | |||
| list(PREPEND CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/cmake/modules") | |||
|
|
|||
| include("cmake/system.cmake") | |||
| include("cmake/llvm.cmake") | |||
| #include("cmake/llvm.cmake") | |||
| include("cmake/linker.cmake") | |||
There was a problem hiding this comment.
@frabert Is this still needed? It does:
if(PLATFORM_LINUX)
set(CMAKE_EXE_LINKER_FLAGS_INIT "-fuse-ld=lld")
set(CMAKE_MODULE_LINKER_FLAGS_INIT "-fuse-ld=lld")
set(CMAKE_SHARED_LINKER_FLAGS_INIT "-fuse-ld=lld")
endif(PLATFORM_LINUX)
There was a problem hiding this comment.
It seems like this should be some higher-level vcpkg thing.
pgoodman
reviewed
Jan 28, 2024
frabert
force-pushed
the
frabert/build-using-vcpkg
branch
from
b88f636 to
dbab145
Compare
frabert
force-pushed
the
frabert/build-using-vcpkg
branch
9 times, most recently
from
ad71520 to
741152e
Compare
frabert
force-pushed
the
frabert/build-using-vcpkg
branch
4 times, most recently
from
dbafd9d to
4fa0717
Compare
frabert
force-pushed
the
frabert/build-using-vcpkg
branch
from
4fa0717 to
43fec61
Compare
frabert
force-pushed
the
frabert/build-using-vcpkg
branch
from
714b9f0 to
05c979e
Compare
frabert
force-pushed
the
frabert/build-using-vcpkg
branch
from
7d5be22 to
8153292
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.