hl: Remove ChooseExpr region type verifier.

trailofbits · Sep 4, 2024 · f8ecacf · f8ecacf
1 parent 432ed1f
commit f8ecacf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/include/vast/Dialect/HighLevel/HighLevelCF.td b/include/vast/Dialect/HighLevel/HighLevelCF.td
@@ -187,6 +187,10 @@ def HighLevel_ChooseExprOp : HighLevel_CondOpBase< "choose_expr" > {
 
   let arguments = (ins OptionalAttr< BoolAttr >:$condTrue);
 
+  // ChooseExpr can have different types.
+  // Often used as __builtin_choose_expr(static_cond, 1, (void)0)
+  let hasRegionVerifier = 0;
+
   let skipDefaultBuilders = 1;
   let builders = [
     OpBuilder<(ins

diff --git a/lib/vast/Dialect/HighLevel/HighLevelOps.cpp b/lib/vast/Dialect/HighLevel/HighLevelOps.cpp
@@ -621,10 +621,6 @@ namespace vast::hl
         return verify_condop_yields(getThenRegion(), getElseRegion(), getLoc());
     }
 
-    logical_result ChooseExprOp::verifyRegions() {
-        return verify_condop_yields(getThenRegion(), getElseRegion(), getLoc());
-    }
-
     logical_result BinaryCondOp::verifyRegions() {
         return verify_condop_yields(getThenRegion(), getElseRegion(), getLoc());
     }