Add new AST interfaces and initial form of UnitializedValues analysis. #682

anthro-poid · 2024-07-29T12:49:58Z

No description provided.

include/vast/Analyses/CFG.hpp

include/vast/Analyses/UninitializedValues.hpp

include/vast/Interfaces/AST/DeclInterface.td

include/vast/Analyses/UninitializedValues.hpp

include/vast/Analyses/Iterators.cpp

include/vast/Interfaces/AST/TypeInterface.td

frabert · 2024-08-12T08:32:48Z

Upstream MLIR uses Analysis instead of Analyses for its directory name, not sure if we want to follow their convention or go with our own.

…/vast/Analysis/Clang/.

…e it compileable.

…nterfaces.

github-actions · 2024-08-12T11:10:07Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 11 file(s) not formatted

include/vast/Analysis/Clang/CFG.hpp
include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp
include/vast/Analysis/Iterators.hpp
include/vast/Analysis/UninitializedValues.hpp
include/vast/Interfaces/AST/DeclInterface.hpp
include/vast/Interfaces/AST/StmtVisitor.h
include/vast/Interfaces/CFG/CFGInterface.hpp
lib/vast/Analysis/Iterators.cpp
lib/vast/Dialect/HighLevel/HighLevelOps.cpp
lib/vast/Interfaces/AST/TypeInterface.cpp
tools/vast-repl/command.cpp

clang-tidy reports: 22 concern(s)

include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp:18:30: error: [clang-diagnostic-error]

use of undeclared identifier 'cfg'
```
   18 |         llvm::PriorityQueue< cfg::CFGBlockInterface,
      |                              ^
```

include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp:19:84: error: [clang-diagnostic-error]

expected member name or ';' after declaration specifiers

   18 |         llvm::PriorityQueue< cfg::CFGBlockInterface,
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   19 |                              llvm::SmallVector< cfg::CFGBlockInterface, QueueSize >,
      |                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^

include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp:22:30: error: [clang-diagnostic-error]

use of undeclared identifier 'cfg'
```
   22 |         DataflowWorklistBase(cfg::CFGInterface Cfg, Comp C)
      |                              ^
```
include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp:23:53: error: [clang-diagnostic-error]

member initializer 'WorkList' does not name a non-static data member or base class
```
   23 |             : EnqueuedBlocks(Cfg.getNumBlockIDs()), WorkList(C) {}
      |                                                     ^~~~~~~~~~~
```
include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp:25:27: error: [clang-diagnostic-error]

use of undeclared identifier 'cfg'
```
   25 |         void enqueueBlock(cfg::CFGBlockInterface Block) {
      |                           ^
```
include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp:28:17: error: [clang-diagnostic-error]

use of undeclared identifier 'WorkList'
```
   28 |                 WorkList.push(Block);
      |                 ^
```
include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp:32:9: error: [clang-diagnostic-error]

use of undeclared identifier 'cfg'
```
   32 |         cfg::CFGBlockInterface dequeue() {
      |         ^
```
include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp:33:17: error: [clang-diagnostic-error]

use of undeclared identifier 'WorkList'
```
   33 |             if (WorkList.empty()) {
      |                 ^
```
include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp:36:13: error: [clang-diagnostic-error]

use of undeclared identifier 'cfg'
```
   36 |             cfg::CFGBlockInterface B = WorkList.top();
      |             ^
```
include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp:36:40: error: [clang-diagnostic-error]

use of undeclared identifier 'WorkList'
```
   36 |             cfg::CFGBlockInterface B = WorkList.top();
      |                                        ^
```
include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp:37:13: error: [clang-diagnostic-error]

use of undeclared identifier 'WorkList'
```
   37 |             WorkList.pop();
      |             ^
```

include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp:45:25: error: [clang-diagnostic-error]

use of undeclared identifier 'cfg'

   45 |         bool operator()(cfg::CFGBlockInterface lhs, cfg::CFGBlockInterface rhs) const {
      |                         ^

include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp:45:53: error: [clang-diagnostic-error]

use of undeclared identifier 'cfg'

   45 |         bool operator()(cfg::CFGBlockInterface lhs, cfg::CFGBlockInterface rhs) const {
      |                                                     ^

include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp:46:13: error: [clang-diagnostic-error]

use of undeclared identifier 'VAST_UNIMPLEMENTED'
```
   46 |             VAST_UNIMPLEMENTED;
      |             ^
```

include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp:57:33: error: [clang-diagnostic-error]

use of undeclared identifier 'cfg'

   57 |         ForwardDataflowWorklist(cfg::CFGInterface Cfg, clang::PostOrderCFGView *POV)
      |                                 ^

include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp:58:11: error: [clang-diagnostic-error]

member initializer 'DataflowWorklistBase' does not name a non-static data member or base class
```
   58 |         : DataflowWorklistBase(Cfg, ReversePostOrderCompare{POV->getComparator()}) {}
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp:60:33: error: [clang-diagnostic-error]

use of undeclared identifier 'cfg'

   60 |         ForwardDataflowWorklist(cfg::CFGInterface Cfg, AnalysisDeclContextInterface Ctx)
      |                                 ^

include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp:60:56: error: [clang-diagnostic-error]

unknown type name 'AnalysisDeclContextInterface'; did you mean 'clang::AnalysisDeclContextManager'?

   60 |         ForwardDataflowWorklist(cfg::CFGInterface Cfg, AnalysisDeclContextInterface Ctx)
      |                                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                        clang::AnalysisDeclContextManager
/usr/lib/llvm-18/include/clang/Analysis/AnalysisDeclContext.h:425:7: note: 'clang::AnalysisDeclContextManager' declared here
  425 | class AnalysisDeclContextManager {
      |       ^

include/vast/Analysis/Clang/FlowSensitive/DataflowWorklist.hpp:63:32: error: [clang-diagnostic-error]

use of undeclared identifier 'cfg'
```
   63 |         void enqueueSuccessors(cfg::CFGBlockInterface Block) {
      |                                ^
```
include/vast/Interfaces/AST/ASTContextInterface.hpp:15:10: error: [clang-diagnostic-error]

'vast/Interfaces/AST/ASTContextInterface.h.inc' file not found
```
   15 | #include "vast/Interfaces/AST/ASTContextInterface.h.inc"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
include/vast/Interfaces/AST/StmtInterface.hpp:17:10: error: [clang-diagnostic-error]

'vast/Interfaces/AST/StmtInterface.h.inc' file not found
```
   17 | #include "vast/Interfaces/AST/StmtInterface.h.inc"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
include/vast/Interfaces/AST/TypeInterface.hpp:21:10: error: [clang-diagnostic-error]

'vast/Interfaces/AST/TypeInterface.h.inc' file not found
```
   21 | #include "vast/Interfaces/AST/TypeInterface.h.inc"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

Have any feedback or feature suggestions? Share it here.

…ion.

anthro-poid closed this Jul 29, 2024

anthro-poid reopened this Jul 29, 2024

anthro-poid force-pushed the clang-cfg-interfaces branch from d084446 to 0acda7e Compare July 29, 2024 13:14

xlauko assigned anthro-poid Jul 30, 2024

xlauko added the Clang static analyzer Experimental support of clang static analyzer over MLIR label Jul 30, 2024

xlauko reviewed Jul 30, 2024

View reviewed changes

anthro-poid requested a review from xlauko July 30, 2024 17:26

anthro-poid force-pushed the clang-cfg-interfaces branch from 64fb227 to 4152a97 Compare July 31, 2024 09:01

Jezurko reviewed Aug 2, 2024

View reviewed changes

include/vast/Analyses/UninitializedValues.hpp Outdated Show resolved Hide resolved

include/vast/Analyses/Iterators.cpp Outdated Show resolved Hide resolved

include/vast/Analyses/Iterators.cpp Outdated Show resolved Hide resolved

Jezurko reviewed Aug 2, 2024

View reviewed changes

include/vast/Interfaces/AST/TypeInterface.td Outdated Show resolved Hide resolved

anthro-poid marked this pull request as ready for review August 5, 2024 08:59

anthro-poid force-pushed the clang-cfg-interfaces branch from e0b9d1b to 8ec5f35 Compare August 12, 2024 10:56

anthro-poid added 17 commits August 12, 2024 13:03

interfaces:ast: Add new interfaces.

fba509e

interfaces:ast: Add new methods and apply new naming conventions.

43ce257

hl: Apply new naming conventions for AST interfaces.

7f64efc

analyses: Add first form of UnitializedValues analysis.

cb12250

analyses: Move all files based on Clang analyses to direcotry include…

da226be

…/vast/Analysis/Clang/.

analyses: Get rid of all _Ts.

1af71cb

analyses: Apply VAST_UNIMPLEMENTED instead of TODO.

8c032df

interfaces:ast: Add new interfaces and use :: before return types.

2fed47c

analysis: Allow to use Visit from StmtVisitor.h.

11bf6ca

analyses: Create Clang directory for files related with Clang analyses.

dedb720

interfaces:ast: Provide implementation for clang::StmtVisitor in vast.

b67c597

interfaces:analyses: Add AnalysisDeclContextInterface.

11eeccf

analyses: Apply changes related to AnalysisDeclContextInterface.

077b04f

interfaces:ast: Make using base public.

643d2a2

interfaces:ast: Apply some naming changes.

936c5c5

interfaces:ast: Unify include format.

55eedc2

analyses: Add iterator for ast::DeclContext.

f5b65db

anthro-poid added 17 commits August 12, 2024 13:04

analyses: Implement another required functionality.

dc78cb1

interfaces:ast: Add several interfaces and methods.

27a9176

analyses: Remove all T suffixes.

4074bae

interfaces:cfg: Add interfaces for Clang CFG classes.

33e6dd2

analyses: Add new iterators.

50df128

analyses: Update DatafloWorklist to use interfaces.

d1f45ec

analyses: Add new functionality to UnitializedValues analysis and mak…

086c4b3

…e it compileable.

hl: Make FuncOp to inherit from DeclContext and AnalysisDeclContext i…

09d7e5d

…nterfaces.

interfaces:ast: Add new methods to Expr interfaces.

5f87f49

interfaces:analysis: Add new methods for AnalysisDeclContext interfaces.

ee1b3e2

interfaces:ast: Add new methods for Type interfaces.

51474e6

interfaces:analysis: Change lib name to resolve conflicts.

e6f8344

repl: Allow repl to run UnitializedVariable analysis.

2697ba8

analyses: Change decl_interface_iterator to use mlir::Operation *.

55a6c89

interfaces:ast: Update interface methods in DeclInterface.td.

78cd574

hl: Provide implementation for FuncOp::decls_begin.

a894a0f

vast: Replace all usages of 'analyses' to 'analysis'.

f7308ba

anthro-poid force-pushed the clang-cfg-interfaces branch from 8ec5f35 to f7308ba Compare August 12, 2024 11:05

anthro-poid added 10 commits September 6, 2024 13:40

analysis: Remove old reprezentation of CFG structures.

858aa92

hl: Attach new interfaces.

b65ea67

core: Attach new interfaces.

eae51e3

interfaces:cfg: Update functionality of CFG interfaces.

6a9e0ed

interfaces:ast: Update DeclInterface and TypeInteface functionality.

8a33d83

core: Add necessary include.

3fc5eeb

analysis: Implement operator++ method for decl_interface_iterator.

c7b42e9

hl: Provide implementations for interface methods.

bc36d28

repl: Allow to call UnitializedVariablesAnalysis from repl.

0bd4da5

analysis: Add current state of UnitializedValues analysis implementat…

e69ef29

…ion.

xlauko closed this Jan 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new AST interfaces and initial form of UnitializedValues analysis. #682

Add new AST interfaces and initial form of UnitializedValues analysis. #682

anthro-poid commented Jul 29, 2024

frabert commented Aug 12, 2024

github-actions bot commented Aug 12, 2024

Add new AST interfaces and initial form of UnitializedValues analysis. #682

Add new AST interfaces and initial form of UnitializedValues analysis. #682

Conversation

anthro-poid commented Jul 29, 2024

frabert commented Aug 12, 2024

github-actions bot commented Aug 12, 2024

Cpp-Linter Report ⚠️