Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add info on SEO slug impact when making changes #1134

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Docs: Add info on SEO slug impact when making changes #1134

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e470ff8
Add info on SEO slug impact when making changes
pjlee11 Jun 27, 2022
83aa6c1
Docs: Add link
pjlee11 Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@ When contributing, please indicate your data sources.
Make sure the tests pass and submit a Pull Request.

It is possible to visualize and edit the data with https://trainline-eu.github.io/stations-studio. In order to make pull requests, you must be member of Trainline EU’s organisation. However it is possible to download the modified file without creating a pull request.

Please note: Changes to station names here not only impact what is shown in the search widget and booking flow, but also the SEO landing page URLs. For more info please see [this wiki](https://wiki.thetrainline.com/display/VUL/SEO+Station+Slugs+solution) on how the "SEO slugs" logic is implemented and the impact of updating a station name.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should incorporate the change, however it would be best to phrase it in an agnostic way without mentionning internal sources.