Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNCF stations update #1320

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

anaalta
Copy link
Contributor

@anaalta anaalta commented Jul 10, 2024

SNCF updated their stations references and some codes were either updated or made obsolete.
This MR deals with 3 such cases:

  1. Rodange station was updated in the SNCF references.
    We were using a virtual station Rodange Frontiere (FRBTS) that was enabled for SNCF only. The virtual station was removed and Rodange station with code LUAAK was enabled for SNCF.
    This case was pointed to us by SNCF.

  2. Hortes station("code": "FRAUF”; “name": "Hortes") was removed from SNCF stations. Since it was not enabled for any other carrier, it is removed from our stations.
    This case is one of the cases for which we got an invalid locality error.

  3. Noirétable station was updated by SNCF:

  • old code FRHLW - place label Noirétable -> new code FRKFK, place label Noiretable Place Passeliere
    It is updated accordingly in our stations, since it's not enabled for any other carrier.

Copy link

➖ Stations removed

472 – Hortes
10439 – Rodange Frontière

Stations changed

  • 3853 – Noirétable Place Passeliere
    • name was changed from Noirétable to Noirétable Place Passeliere
    • slug was changed from noiretable to noiretable-place-passeliere
    • sncf_id was changed from FRHLW to FRKFK
  • 8599 – Rodange
    • sncf_is_enabled is now enabled ✅

@ConscritNeuneu ConscritNeuneu merged commit 9315c96 into trainline-eu:master Jul 10, 2024
1 check passed
stations.csv Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants