Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework A Gudiña stations #1340

Merged

Conversation

ConscritNeuneu
Copy link
Member

@ConscritNeuneu ConscritNeuneu commented Sep 9, 2024

The historic train station is being demolished. The new station of A Gudiña
is A Gudiña – Porta de Galicia.

  • Mark 23639 as is_city (even if it's slightly contentious)
  • Remove renfe code and renfe_is_enabled for 23639
  • Add is_main_station hint on 74642 A Gudiña – Porta de Galicia
  • Mark 23639 as parent of 74642

This should prompt the renfe code to use this station when searching.

@ConscritNeuneu ConscritNeuneu force-pushed the a_gudina_porta_de_galicia branch 2 times, most recently from 35e14ab to 4ed420f Compare September 9, 2024 14:30
The historic train station is being demolished. The new station of A Gudiña
is A Gudiña – Porta de Galicia.

- Mark 23639 as is_city (even if it's slightly contentious)
- Remove renfe code and renfe_is_enabled for 23639
- Add is_main_station hint on 74642 A Gudiña – Porta de Galicia
- Mark 23639 as parent of 74642

This should prompt the renfe code to use this station when searching.
@ConscritNeuneu ConscritNeuneu force-pushed the a_gudina_porta_de_galicia branch from 4ed420f to 5d19d14 Compare September 9, 2024 14:32
@lucavezz lucavezz self-assigned this Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Stations changed

  • 23639 – A Gudiña
    • is_city was changed from f to t
    • db_id was removed, value was 7100390
    • renfe_id was removed, value was 31205
    • renfe_is_enabled is now disabled ❌
  • 74642 – A Gudiña – Porta de Galicia
    • parent_station_id was added, value is 23639
    • is_main_station was changed from f to t

@lucavezz lucavezz merged commit cb2134b into trainline-eu:master Sep 9, 2024
1 check passed
@ConscritNeuneu ConscritNeuneu deleted the a_gudina_porta_de_galicia branch September 9, 2024 15:18
@ConscritNeuneu
Copy link
Member Author

Grazie!

MontseBadia pushed a commit to MontseBadia/stations that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants