Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ashford #1352

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix Ashford #1352

merged 1 commit into from
Sep 26, 2024

Conversation

ConscritNeuneu
Copy link
Member

@ConscritNeuneu ConscritNeuneu commented Sep 25, 2024

There are two Ashford stations. Both are called Ashford International but
one is for national rail services (CRS AFK, as in AshFord Kent) and one is
for international rail services (CRS ASI AShford International). Various
mix-up occured in the data.

  • 7968 was probably intended to be the international services station.
    Adding the proper SNCF code to it. Removing the same_as column and add the
    CRS code for it.
  • 8154 is the meta station. It has ATOC group code 386. SNCF knows it by
    code GBASD.
  • 8155 was intended to be Ashford International national services,
    guessing from the normalised code. It has CRS code AFK and SNCF code GBAJC.
  • 22673 was deleted. It has a same_as, generally indicating a
    misunderstanding of the subtelties. It did not contain meaningful
    information.

Also

  • remove DB and Bene ids on Ashford as they're not served by these
    carriers and until the situation is made clearer
  • add the remaining normalised codes corresponding to each station / group

Finally, there is some confusion in the UIC data and the NLOCs, did my best
to collate the data.

There are two Ashford stations. Both are called Ashford International but
one is for national rail services (CRS AFK, as in AshFord Kent) and one is
for international rail services (CRS ASI AShford International). Various
mix-up occured in the data.

- 7968 was probably intended to be the international services station.
  Adding the proper SNCF code to it. Removing the same_as column and add the
  CRS code for it.
- 8154 is the meta station. It has ATOC group code 386. SNCF knows it by
  code GBASD.
- 8155 was intended to be Ashford International *national* services,
  guessing from the normalised code. It has CRS code AFK and SNCF code GBAJC.
- 22673 was deleted. It has a same_as, generally indicating a
  misunderstanding of the subtelties. It did not contain meaningful
  information.

Also
- remove DB and Bene ids on Ashford as they're not served by these
carriers and until the situation is made clearer
- add the remaining normalised codes corresponding to each station / group

Finally, there is some confusion in the UIC data and the NLOCs, did my best
to collate the data.
Copy link

➖ Stations removed

22673 – Ashford International

Stations changed

  • 7968 – Ashford International
    • uic was added, value is 7054660
    • uic8_sncf was added, value is 70546606
    • latitude was changed from 51.143434 to 51.142943
    • longitude was changed from 0.875153 to 0.874444
    • sncf_id was changed from GBAJC to GBASI
    • db_id was removed, value was 7000107
    • atoc_id was added, value is ASI
    • benerail_id was removed, value was GBAJC
    • same_as was removed, value was 8155
    • normalised_code was added, value is urn:trainline:public:nloc:at005476
  • 8154 – Ashford
    • uic was removed, value was 7070512
    • uic8_sncf was removed, value was 70705129
    • latitude was added, value is 51.14334
    • longitude was added, value is 0.87516
    • atoc_id was added, value is 386
    • normalised_code was added, value is urn:trainline:public:nloc:at000115
  • 8155 – Ashford International
    • uic was changed from 7054660 to 7050040
    • uic8_sncf was changed from 70546606 to 70500405
    • latitude was changed from 51.143353 to 51.143785
    • longitude was changed from 0.875167 to 0.876446
    • sncf_id was changed from GBASI to GBAJC
    • db_id was removed, value was 7098107
    • renfe_id was removed, value was 7000512
    • benerail_id was removed, value was GBASI

Copy link
Contributor

@misdoro misdoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let it be.

Ideally we would want 4 stations:

Ashford <- city station, can be used for bus/coach integrations
Ashford international <- metastation, child of the city and parent of the two below
Ashford international (NRS, SuthEastern)
Ashford international (international, Eurostar)

if at some point there will be bus services, they will be sold linked to the city (or another rather than meta-station.

@misdoro misdoro merged commit 05efac7 into trainline-eu:master Sep 26, 2024
1 check passed
@ConscritNeuneu
Copy link
Member Author

❤️

@ConscritNeuneu ConscritNeuneu deleted the ashford branch September 26, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants