Add & update Trenitalia RTVTID's and correct SNCF UIC8 check bits #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Brescello-Viadana * Como Camerlata * Veggia * Codisotto * Ceriano Laghetto-Groane * Pratissolo * Pm Teatino
* Basel St. Johann * Bruxelles-Midi * Barcelona Sants * Luxembourg * Bettembourg
Stations changed
|
|
The UIC-8 checksum is standardized under TAP-TSI: Voyages SNCF is not responsible for coding of stations, it's SNCF Réseau (see the dataset here ) and it's only authoritative in France. Outside of France the codes used by SNCF are just a suggestion. |
|
Splitting into 2 separate PR's, one for SNCF and one for Trenitalia. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further to recent investigations, I have found some stations that have missing or incorrect ID's.
It seems as though some SNCF stations not in France especially, had incorrect checksum bits set.
These changes have all been confirmed with public API responses.