Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stations.csv #1405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

achrafSallemi
Copy link

We need to improve Airports stations search on Navan side. When users search for Vienna Airport. they get nothing, the reason for that the translations are not descriptive. The goal here s to improve stations localisation.

updated vienna airport station translations
Copy link

Stations changed

  • 23019 – Flughafen Wien
    • info:de was added, value is Flughafen Wien
    • info:en was changed from Vienna to Vienna Airport
    • info:es was changed from Viena to Aeropuerto de Viena
    • info:fr was changed from Vienne to Aéroport de Vienne
    • info:it was changed from Vienna to Aeroporto di Vienna
    • info:nl was changed from Wenen to Luchthaven Wenen
    • info:pl was added, value is Lotnisko Wiedeń
    • info:pt was added, value is Aeroporto de Viena
    • info:sv was added, value is Wiens flygplats

@ConscritNeuneu
Copy link
Member

This change is great IMO as info is… well… an info not a translation. We'll have to think about what to do with the test as the flag is obviously not surfaced to you (or else I guess you wouldn't have to propose this change).

I noticed that your editor has transformed all the line feeds (\n) at the end of each line into carriage return + line feed (\r\n), which results into an unnecessary large diff. Could you correct it please?

@ConscritNeuneu
Copy link
Member

So after some internal discussion, the flag is_airport is consumed but not exposed to the global API, we're going to do this work properly rater than change info.

@achrafSallemi
Copy link
Author

achrafSallemi commented Feb 20, 2025

@ConscritNeuneu thanks for checking this. I do not understand this point: I noticed that your editor has transformed all the line feeds (\n) at the end of each line into carriage return + line feed (\r\n), which results into an unnecessary large diff.
Can you explain it more please or suggest a change? I see small changes on the PR
Screenshot 2025-02-20 at 16 07 52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants