Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check precedences of metadata #99

Merged
merged 12 commits into from
Oct 18, 2023
Merged

Conversation

yangsophieee
Copy link
Collaborator

Addresses #60, checking precedence of metadata fields across various sections of metadata are working correctly (e.g. location > trait metadata)

  • Added additional testing for checking precedence of metadata
  • Fixed an error with dataset_test where I didn't realise the data variable already uses process_custom_code so it was applying it twice
  • Removed old testing files
  • Small formatting changes
  • @ehwenk and I agree that trait metadata should probably take precedence over location metadata but we will leave this to a later date (trait metadata is read in via process_parse_data and location metadata replaces it afterwards in dataset_process around Line 141, so you'd have to move the location metadata part into process_parse_data, which will presumably require splitting location data into location properties vs the other variables and having them input at different times)

@yangsophieee yangsophieee requested a review from dfalster October 18, 2023 02:57
@dfalster
Copy link
Member

Let me know once passing and I can review!

@yangsophieee
Copy link
Collaborator Author

@dfalster it's passing now! Thanks :)

@yangsophieee yangsophieee merged commit 84d0ca8 into develop Oct 18, 2023
3 checks passed
@yangsophieee yangsophieee deleted the check_precedences_of_metadata branch October 18, 2023 05:05
@yangsophieee yangsophieee restored the check_precedences_of_metadata branch October 18, 2023 05:05
@yangsophieee yangsophieee deleted the check_precedences_of_metadata branch October 18, 2023 05:05
@yangsophieee yangsophieee restored the check_precedences_of_metadata branch October 18, 2023 05:05
@yangsophieee yangsophieee deleted the check_precedences_of_metadata branch October 18, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants