-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B-21359 - Backend: Assigned User Cleanup #14330
base: main
Are you sure you want to change the base?
Conversation
erge branch 'B-21359-main' of https://github.com/transcom/mymove into B-21359-main
…o B-21359-main
@@ -35,6 +35,30 @@ func BuildMove(db *pop.Connection, customs []Customization, traits []Trait) mode | |||
closeoutOffice = BuildTransportationOffice(db, tempCloseoutOfficeCustoms, nil) | |||
} | |||
|
|||
var scAssignedUser models.OfficeUser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't showing as part of your INT pr, lines 38-44
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked to Jon and noted this is because of 21337 going into INT first, but it's not yet in Main.
tempTIOAssignedUserCustoms = convertCustomizationInList(tempTIOAssignedUserCustoms, OfficeUsers.TIOAssignedUser, OfficeUser) | ||
tioAssignedUser = BuildOfficeUser(db, tempTIOAssignedUserCustoms, nil) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You seem to be missing some lines here from your INT PR, for counselingOffice.
pkg/factory/shared.go
Outdated
@@ -271,6 +271,18 @@ var TransportationOffices = transportationOfficeGroup{ | |||
CloseoutOffice: "CloseoutOffice", | |||
} | |||
|
|||
type officeUserGroup struct { | |||
SCAssignedUser CustomType | |||
TOOAssignedUser CustomType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have these in a different order in your int PR, can swap TIO and TOO here so they match int? And ines 282-283 below please.
Agility ticket
Summary
Once an assigned office user has completed their task on a move, we need to clean up that assigned and remove them from the move.
Steps to create
Screenshots
INT PR