Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-21359 - Backend: Assigned User Cleanup #14330

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

B-21359 - Backend: Assigned User Cleanup #14330

wants to merge 42 commits into from

Conversation

JonSpight
Copy link
Contributor

@JonSpight JonSpight commented Dec 4, 2024

Agility ticket

Summary

Once an assigned office user has completed their task on  a move, we need to clean up that assigned and remove them from the move.

Steps to create

  1. Create a move and assign an office user in the Service Counseling Queue
  2. Submit the move for TOO Approval
  3. Check DB to verify the previously assigned users no longer assigned
  4. Assign an office user in the Task Order Queue and approve the move as a TOO
  5. Check DB to verify the previously assigned users no longer assigned
  6. Update the shipment and create service items via Prime
  7. Approve one of the service item as TOO, (have at least one remaining un-reviewed service item)
  8. Navigate back to the Task Oder Queue and verify the move is still assigned and is not assignable
  9. Reject a service item as TOO, (have at least one remaining un-reviewed service item)
  10. Navigate back to the Task Oder Queueand verify the move is still assigned and is not assignable
  11. Approve or reject the last service item
  12. Navigate back to the Task Oder Queueand verify the move is no longer assigned and is now assignable
  13. Create 2 payment requests via Prime
  14. Assign an office user in the Payment Request Queue
  15. Approve one payment request as a TIO
  16. Navigate back to the payment request Queue and verify the move is still assigned
  17. Approve the remaining payment request as a TIO
  18. Check DB to verify the previously assigned users is no longer assigned
  19. Create a 2 payment requests via Prime
  20. Assign an office user in the Payment Request Queue
  21. Reject one payment request as a TIO
  22. Navigate back to the payment request Queue and verify the move is still assigned
  23. Reject the remaining payment request as a TIO
  24. Check DB to verify the previously assigned users is no longer assigned

Screenshots

INT PR

@JonSpight JonSpight self-assigned this Dec 4, 2024
@JonSpight JonSpight marked this pull request as ready for review January 8, 2025 19:55
@JonSpight JonSpight requested a review from a team as a code owner January 8, 2025 19:55
@@ -35,6 +35,30 @@ func BuildMove(db *pop.Connection, customs []Customization, traits []Trait) mode
closeoutOffice = BuildTransportationOffice(db, tempCloseoutOfficeCustoms, nil)
}

var scAssignedUser models.OfficeUser
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't showing as part of your INT pr, lines 38-44

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to Jon and noted this is because of 21337 going into INT first, but it's not yet in Main.

tempTIOAssignedUserCustoms = convertCustomizationInList(tempTIOAssignedUserCustoms, OfficeUsers.TIOAssignedUser, OfficeUser)
tioAssignedUser = BuildOfficeUser(db, tempTIOAssignedUserCustoms, nil)
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to be missing some lines here from your INT PR, for counselingOffice.

@@ -271,6 +271,18 @@ var TransportationOffices = transportationOfficeGroup{
CloseoutOffice: "CloseoutOffice",
}

type officeUserGroup struct {
SCAssignedUser CustomType
TOOAssignedUser CustomType
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have these in a different order in your int PR, can swap TIO and TOO here so they match int? And ines 282-283 below please.

@JonSpight JonSpight requested a review from pambecker January 8, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants