-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B-21337-MAIN Bulk assignment data fetch setup #14371
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of my comments are things you'd probably catch and remove, but weed through them and we can take a look at this next week as you refine the approach. Don't hate it though.
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
resolving @danieljordan-caci's comments as they were intended for the INT pr |
Marking as ready for review since I will be out tomorrow, but we expect this to be moved to Review/Merge Staging tomorrow (Jan 10) |
Test coverage on client failed.Last run: Thu 09 Jan 2025 05:25:12 PM UTC |
Code matches up, I'll approve once the BL has POA note available. |
Agility ticket
INT PR
INT PR 2