-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAIN - B-21905 - Rename NTS shipment type #14418
Conversation
|
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Waiting on #14304 to get merged in. Modified code in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only difference is the change mentioned in the comment which is in Aaron's PR, other than that looks like the MAIN and INT PR's are identical. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once conflict is resolved it's good to go
lgtm 👽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just saw the other comments lol
Should be good now @WeatherfordAaron |
B-21905
INT PR: #14419
Summary
This is to change current NTS shipment type,
HHG_INTO_NTS_DOMESTIC
toHHG_INTO_NTS
since we will be using these for international shipments. This change applies to everywhere in the app including the enum in the DB.How to test
HHG_INTO_NTS
in the DB forshipment_type
inmto_shipments
table.HHG_INTO_NTS
as the shipment type in prime GET api.Screenshots