-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INT B-21707 #14473
INT B-21707 #14473
Conversation
… baby jesus in a tuxedo
…ing post region city ids
migrations/app/schema/20241226173330_add_intl_param_values_to_service_params_table.up.sql
Outdated
Show resolved
Hide resolved
pkg/payment_request/service_param_value_lookups/per_unit_cents_lookup.go
Show resolved
Hide resolved
pkg/payment_request/service_param_value_lookups/port_name_lookup.go
Outdated
Show resolved
Hide resolved
pkg/payment_request/service_param_value_lookups/port_name_lookup_test.go
Outdated
Show resolved
Hide resolved
src/components/PrimeUI/CreatePaymentRequestForm/CreatePaymentRequestForm.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I should be done now. Didn't realize that I was using the pickup <-> destination ZIP distance when I should've been using pickup/destination <-> port ZIP distance. Please re-review when you get a chance @brianmanley-caci & @cameroncaci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked great, conducted all testing via postman and couldn't break it
Agility ticket
Summary
We want the Prime to be able to submit payment requests for basic international HHG service items. This work was kind of a beast because I had to set up pricing for service items that involved some database work and updating the
service_params
&service_item_param_keys
tables. This PR does the following:us_post_region_cities_id
when addresses are created through factoryget_rate_area_id
db func from there_rate_area
model file (this is needed to get a lot of pricing data)per_unit_cents
value from respective international pricing tables - I think this will be good to avoid excessive db calling in the pricing function because we can store it instead of keep looking for itPOEFSC
orPODFSC
service item - I'd like to display this to the TIO when they are reviewing (this work is downstream)ISLH
,IHPK
,IHUPK
, &POEFSC
/PODFSC
How to test
iHHG
shipmentISLH
,IHPK
, andIHUPK
service items - we need to update the port to get the payment request working forPOEFSC
/PODFSC
eTag
for the fuel surcharge service item (Prime v3getMoveTaskOrder
) & the service itemid
- swagger UI makes it easyeTag
Screenshots