Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT B-21707 #14473

Merged
merged 17 commits into from
Jan 6, 2025
Merged

INT B-21707 #14473

merged 17 commits into from
Jan 6, 2025

Conversation

danieljordan-caci
Copy link
Contributor

@danieljordan-caci danieljordan-caci commented Dec 26, 2024

Agility ticket

Summary

We want the Prime to be able to submit payment requests for basic international HHG service items. This work was kind of a beast because I had to set up pricing for service items that involved some database work and updating the service_params & service_item_param_keys tables. This PR does the following:

  • adds migration to update relevant tables with needed param keys for iHHG service items & other accessorials
  • updated the address factory to populate us_post_region_cities_id when addresses are created through factory
  • added ability for partial weight billing for basic iHHG service items
  • added the ability to call the get_rate_area_id db func from the re_rate_area model file (this is needed to get a lot of pricing data)
  • added lookup to get the per_unit_cents value from respective international pricing tables - I think this will be good to avoid excessive db calling in the pricing function because we can store it instead of keep looking for it
  • added lookup to get the port name that is attached to the POEFSC or PODFSC service item - I'd like to display this to the TIO when they are reviewing (this work is downstream)
  • added pricers for ISLH, IHPK, IHUPK, & POEFSC/PODFSC
  • mocks
  • updated prime sim UI to allow for creating payment requests & partial weight billing
  • code cleanup & tests

How to test

  1. Go ahead and create a move as a customer/SC with an iHHG shipment
  2. Approve as TOO to make it available to the prime
  3. Update the estimated weight and all required data
  4. At this point you can create a payment request for ISLH, IHPK, and IHUPK service items - we need to update the port to get the payment request working for POEFSC/PODFSC
  5. You're gonna need two things: the eTag for the fuel surcharge service item (Prime v3 getMoveTaskOrder) & the service item id - swagger UI makes it easy
  6. Now you will need to update the port of the service item by using prime v1 updateServiceItem - make sure you got that eTag
  7. Payload can look like this (using your respective values):
{   
   "id": "4cc44e88-231f-4f49-8180-4d7012be17b3",   
   "modelType": "UpdateMTOServiceItemInternationalPortFSC",   
   "portCode": "SEA",   
   "reServiceCode": "POEFSC" 
}
  1. You could also just update the db manually, but it's up to you
  2. Now go ahead and create a payment request for all basic service items (or just the fuel surcharge if you did the others already)
  3. Everything should be successful and you should be able to review as TIO - breakdown/details are coming in a downstream BL
  4. Verify you can also see the updated documentation: use swagger

Screenshots

Screenshot 2025-01-02 at 4 41 07 PM
Screenshot 2025-01-02 at 4 41 20 PM
Screenshot 2025-01-02 at 4 41 24 PM

@danieljordan-caci danieljordan-caci self-assigned this Dec 26, 2024
@danieljordan-caci danieljordan-caci added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Dec 26, 2024
@danieljordan-caci danieljordan-caci requested a review from a team as a code owner January 3, 2025 19:21
Copy link
Contributor

@brianmanley-caci brianmanley-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well for me 🎉

image

@danieljordan-caci
Copy link
Contributor Author

Working well for me 🎉

image

Re-requesting review - forgot to update the API docs per the BL AC

@brianmanley-caci
Copy link
Contributor

Re-requesting review - forgot to update the API docs per the BL AC

Still good, and I can see the api doc updates.

Screenshot 2025-01-03 at 4 56 41 PM
Screenshot 2025-01-03 at 4 56 59 PM

@danieljordan-caci
Copy link
Contributor Author

Okay I should be done now. Didn't realize that I was using the pickup <-> destination ZIP distance when I should've been using pickup/destination <-> port ZIP distance.

Please re-review when you get a chance @brianmanley-caci & @cameroncaci

Copy link
Contributor

@traskowskycaci traskowskycaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good for me! Tested with a domestic zip to two separate AK zips:
image

Copy link
Contributor

@cameroncaci cameroncaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked great, conducted all testing via postman and couldn't break it

@danieljordan-caci danieljordan-caci merged commit cb10ad2 into integrationTesting Jan 6, 2025
32 of 34 checks passed
@danieljordan-caci danieljordan-caci deleted the INT-B-21707 branch January 6, 2025 18:31
This was referenced Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

4 participants