B 21569 int

[stevengleason-caci]

B-21569 INT

B-21569

Summary

Add service items for Unaccompanied Baggage. They are visible after the shipment is Approved and Submitted. They cane be Rejected and re-Approved.

The feature mentions that the Fuel Surcharge is only for when either the Origin or Destination is CONUS.
The story mentions using the DB, but I saw that other similar stories were putting it directly in reServiceCodesForShipment.

Verification Steps for the Author

These are to be checked by the author.

• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

1. Run with feature flags on: FEATURE_FLAG_UNACCOMPANIED_BAGGAGE=true FEATURE_FLAG_ENABLE_ALASKA=true make server_run
2. Login as a Customer and create an OCONUS-to-CONUS UB shipment
3. And create an OCONUS-to-OCONUS UB shipment
4. Log in as a Counselor and complete and approve both shipments
5. Log in as a TOO and submit the OCONUS-to-CONUS shipment
6. See the 4 service items
7. Submit the OCONUS-to-OCONUS shipment
8. See only 3 service items (no Fuel Surcharge)

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots

OCONUS-CONUS with FSC

OCONUS-OCONUS (no FSC)

[ryan-mchugh]

I noticed that FSC still shows in the preview for OCONUS-OCONUS UB shipments