B-22137 & B-22170 update pdfcpu 0.6.0 to latest 0.9.1 #14496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameroncaci
added
Mountain Movers
cameroncaci
changed the title
cameroncaci
force-pushed
the
prod-fix-pdfcpu-int
branch
from
1bca744 to
c7bc57f
Compare
This reverts commit 56d7691.
cameroncaci
force-pushed
the
prod-fix-pdfcpu-int
branch
from
e5306f0 to
2af3665
Compare
cameroncaci
requested review from
deandreJones,
a team,
danieljordan-caci,
TevinAdams and
traskowskycaci
|
AOA-01-16-2025_15-47-40.pdf |
josiahzimmerman-caci
approved these changes
Jan 16, 2025
|
ppm_payment_packet-2025-01-16T15_56_58.039Z.pdf |
|
able to upload supporting docs' |
|
|
deandreJones
approved these changes
Jan 16, 2025
cameroncaci
changed the title
|
NOOOOO NOT THE FLAKY TESTS |
|
rerunning from failed pipeline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current ticket B-22170
Originated from B-22137
Summary
Production containers encountering stack overflow on pdfcpu call.
Pdfcpu issue 867 was resolved in May of this year. Our current pdfcpu package
0.6.0dates back to December 2023. Updating to latest0.9.1to attempt fixing issue.Docker changes
We now mount a separate volume in docker to not abide by the readonly aws ecs root marking a dedicated mutable directory. Pdfcpu uses this to install and write fonts because it doesn't do it on compile, it installs fonts and such after compile.
Misc changes
Disabled watermarks in paperwork package generator. Watermarks never worked, they are using bookmark specific code. Enhanced by adding a pre-emptive nil check and then disabled it. The pre-emptive nil check will come in handy should a feature come through requesting watermarking.
Additionally, fixed some existing err return issues
How to test
Anything that's got to do with milmove PDF generation, make sure it works! AOA/SSW/PPM you name it if it's PDF generated we want to make sure it works
Related
pdfcpu/pdfcpu#867 <- May 2024
pdfcpu/pdfcpu#268 <- December 2020