MAIN - B-22146 - Defect - Incorrect mileage destination SIT

[taeJungCaci]

B-22146

INT PR: #14515

Summary

This is to fix couple of issues that were occurring with following conditions:

1. Destination SIT service items have been approved.
2. A destination address update is made after Destination SIT service items have been approved.
3. Payment request for service items are made by Prime.

One issue was that when TIO is reviewing the payment request, Mileage shown were incorrect for DLH, DSH, FSC other Destination SIT related items while the destination ZIP was correct. It should be the destination address at the time of Destination SIT approval and not the new updated address.

Second issue was that when an address update was made 2 or more times, the destination ZIP would lag 1 update behind and display the incorrect ZIP for Domestic linehaul and other related service items.

After some extensive digging in the code for Destination SIT service items, I've refactored existing condition checks in service_param_value_lookups/distance_zip_lookup.go and the function in service_param_value_lookups/service_param_value_lookups.go. The issue was partly due to using addresses in DeliveryAddressUpdate model and not SITDestinationOriginalAddress field stored in the SIT service item.

Also, not sure if mtoShipment.Distance is used anywhere for HHG, but since the code was in the file from long long time ago, I've updated it to handle the case when there is a destination SIT so it save the distance from pickup zip to destination zip.

How to test

Now we need to go through the flow of creating a Destination SIT service item -> update destination address -> then payment request.

1. As a customer -> create a move and use 98204 for pickup address zip and 92136 as destination address zip(click Yes when asked if you know deliver address yet) when creating a HHG shipment.
2. Submit as SC -> approve as TOO.
3. As Prime -> click update shipment -> put in future dates for fields in Shipment dates section. Add estimated weight and actual weight -> then choose any Destination type at the bottom off the page. -> Save.
4. As Prime -> Click Add Service Item -> Choose Destination SIT and fill in dates and time.
5. As TOO -> Move task order tab -> Approve all 4 SIT requests.
6. As Prime -> Click Update Shipment Delivery Address put 91913 in the Location Lookup and select that zip. -> add remarks and Save and Save.
7. As TOO -> Edit shipment -> Click See delivery address to proceed link at the top -> Click Review request in the warning message -> Click Yes and add in remarks and Save.
8. As Prime -> Create Payment Request -> Select Domestic linehaul, Fuel surcharge, Domestic destination 1st day SIT, Domestic destination SIT delivery, and Domestic destination SIT fuel surcharge then submit request.
9. As TIO -> Click Review service items in Payment requests tab -> Click show calculations to verify the zip and mileage for each service items. The correct destination zip for Domestic linehaul and fuel surcharge should be 92136 and the mileage should be 1321. For Domestic destination SIT fuel surcharge, zip should be 92136 to 91913.

Screenshots

[taeJungCaci]

Noting the conflict in this file with https://github.com/transcom/mymove/pull/14473/files#diff-273c985eb96393188de58e7e495a5e9863fa7cd6fa777b1bad0931224c13e7c6