Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT B-21983 - Display Counseling Office in Move Details (Review After B-21977) #14538

Open
wants to merge 21 commits into
base: integrationTesting
Choose a base branch
from

Conversation

ajlusk
Copy link
Contributor

@ajlusk ajlusk commented Jan 8, 2025

B-21983

Summary

Includes changes from B-21977

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Access the office app as a services counselor
  2. Open or create a move that has a populated counseling office (most of the seed data doesn't)
  3. Verify the counseling office is displayed in the orders card.
  4. Repeat with a TOO and/or TIO as they use a different move details component.

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

@ajlusk ajlusk added Scrummy Bears Scrum Team H INTEGRATION Slated for Integration Testing labels Jan 8, 2025
@ajlusk ajlusk self-assigned this Jan 8, 2025
@ajlusk ajlusk changed the title INT B-21983 - Display Counseling Office in Move Details INT B-21983 - Display Counseling Office in Move Details (Review After B-21977) Jan 8, 2025
@ajlusk ajlusk marked this pull request as ready for review January 8, 2025 23:50
@ajlusk ajlusk requested a review from a team as a code owner January 8, 2025 23:50
@ajlusk ajlusk requested a review from a team as a code owner January 8, 2025 23:50
@@ -437,6 +439,18 @@ func GBLOCs(gblocs []string) ghcmessages.GBLOCs {
return payload
}

func CounselingOffices(counselingOffices models.TransportationOffices) ghcmessages.CounselingOffices {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add unit test to increase code coverage

Copy link
Contributor

@MInthavongsay MInthavongsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Verified counseling office is now displayed in Order card view for TOO/TIO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H
Development

Successfully merging this pull request may close these issues.

2 participants