-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INT B-21983 - Display Counseling Office in Move Details (Review After B-21977) #14538
Open
ajlusk
wants to merge
21
commits into
integrationTesting
Choose a base branch
from
B-21983-INT
base: integrationTesting
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen creating a move
ajlusk
added
Scrummy Bears
Scrum Team H
INTEGRATION
Slated for Integration Testing
labels
Jan 8, 2025
ajlusk
changed the title
INT B-21983 - Display Counseling Office in Move Details
INT B-21983 - Display Counseling Office in Move Details (Review After B-21977)
Jan 8, 2025
ajlusk
requested review from
MInthavongsay,
antgmann,
r-mettler and
CoryKleinjanCACI
January 8, 2025 23:47
@@ -437,6 +439,18 @@ func GBLOCs(gblocs []string) ghcmessages.GBLOCs { | |||
return payload | |||
} | |||
|
|||
func CounselingOffices(counselingOffices models.TransportationOffices) ghcmessages.CounselingOffices { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add unit test to increase code coverage
MInthavongsay
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Verified counseling office is now displayed in Order card view for TOO/TIO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-21983
Summary
Includes changes from B-21977
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots