Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 22129 INT closeout data #14540

Merged
merged 24 commits into from
Jan 21, 2025
Merged

Conversation

loganwc
Copy link
Contributor

@loganwc loganwc commented Jan 8, 2025

Agility ticket

Summary

Add SC Closeout queue data to bulk assignment endpoint

This requires 21339 if you want to see the data in the modal

How to test

  1. Create an Army/USAF and a Navy/USCG/USMC PPM and complete until Needs Closeout status
  2. Create 2 Office Users (1 supervisor and 1 regular) with the same office as the moves closeout office
  3. Add these lines to ServicesCounselingQueue.jsx:
const { bulkAssignmentData } = useBulkAssignmentQueries('CLOSEOUT');
console.log(bulkAssignmentData);
  1. Verify the payload does not include the Navy/USCG/USMC moves and has the Army/USAF moves and office users.

Screenshots

Screenshot 2025-01-07 at 7 51 25 PM

@loganwc loganwc added G-Unit Scrum Team G INTEGRATION Slated for Integration Testing labels Jan 8, 2025
@loganwc loganwc self-assigned this Jan 8, 2025
@loganwc loganwc mentioned this pull request Jan 8, 2025
@loganwc loganwc marked this pull request as ready for review January 9, 2025 16:07
@loganwc loganwc requested a review from a team as a code owner January 9, 2025 16:07
@loganwc loganwc requested review from a team as code owners January 14, 2025 16:48
@pambecker
Copy link
Contributor

The AC in the backlog says that this story should be populating the data in the modal, I don't see that anywhere in here.

@loganwc
Copy link
Contributor Author

loganwc commented Jan 15, 2025

The AC in the backlog says that this story should be populating the data in the modal, I don't see that anywhere in here.

the modal isn't fully implemented yet, that story needs to come first
21339

@pambecker
Copy link
Contributor

The AC in the backlog says that this story should be populating the data in the modal, I don't see that anywhere in here.

the modal isn't fully implemented yet, that story needs to come first 21339

Sounds good, I do remember some discussion on this possibly happening. Then we need to get a new story created to move that AC to, once done, please post the BL # here. thanks.

pambecker
pambecker previously approved these changes Jan 15, 2025
pkg/handlers/ghcapi/queues.go Show resolved Hide resolved
pkg/services/move/move_fetcher.go Show resolved Hide resolved
@deandreJones deandreJones removed the request for review from a team January 16, 2025 13:47
@loganwc loganwc merged commit ad67bbc into integrationTesting Jan 21, 2025
32 of 33 checks passed
@loganwc loganwc deleted the B-22129-INT-Closeout-Data branch January 21, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
G-Unit Scrum Team G INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

4 participants