Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INT B-21964 #14697

Closed
wants to merge 3 commits into from
Closed

INT B-21964 #14697

wants to merge 3 commits into from

Conversation

danieljordan-caci
Copy link
Contributor

@danieljordan-caci danieljordan-caci commented Jan 30, 2025 •
edited
Loading

Agility ticket

Summary

We want to let the admins search by transportation office within the admin application. This required some refactoring of the list fetcher because the FetchMany does not allow for searching of nested associations.

How to test

  1. You'll need some prep first
  2. Go and fill out the request account for office users a few times
  3. Okay, now go sign into the admin application
  4. You should now see those requested office users
  5. Play around with the search boxes - one should handle name/email, the other should handle transpo office

Screenshots

Screen.Recording.2025-01-30.at.9.39.50.AM.mov

Screenshot 2025-01-30 at 9 40 40 AM

@danieljordan-caci danieljordan-caci added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Jan 30, 2025
@danieljordan-caci danieljordan-caci requested review from KonstanceH and a team January 30, 2025 15:49
@danieljordan-caci danieljordan-caci self-assigned this Jan 30, 2025
@danieljordan-caci danieljordan-caci requested review from a team as code owners January 30, 2025 15:49
@danieljordan-caci danieljordan-caci mentioned this pull request Jan 30, 2025
Open
15 tasks
@robot-mymove
Copy link

robot-mymove commented Jan 30, 2025 •
edited
Loading

Warnings
⚠️ This PR does not include changes to unit tests, even though it affects app code.

Generated by 🚫 dangerJS against 83b5ab8

TevinAdams
TevinAdams requested changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@TevinAdams TevinAdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danieljordan-caci I already did this.

@danieljordan-caci
Copy link
Contributor Author

@danieljordan-caci I already did this.

Mine is refactoring - which I'd rather have, messing with merge conflicts now

@TevinAdams TevinAdams self-requested a review January 31, 2025 14:45
@TevinAdams
Copy link
Contributor

Everything looks good. Only thing I noticed was the sort on transportation office was no longer working. Also like the approach of leveraging the pop queries.

@danieljordan-caci
Copy link
Contributor Author

Closing as this work seems to be covered under @TevinAdams's B-21961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonstanceH KonstanceH Awaiting requested review from KonstanceH

@deandreJones deandreJones Awaiting requested review from deandreJones deandreJones was automatically assigned from transcom/mountain-movers

@cameroncaci cameroncaci Awaiting requested review from cameroncaci cameroncaci was automatically assigned from transcom/mountain-movers

@traskowskycaci traskowskycaci Awaiting requested review from traskowskycaci traskowskycaci was automatically assigned from transcom/mountain-movers

@TevinAdams TevinAdams Awaiting requested review from TevinAdams

Assignees

@danieljordan-caci danieljordan-caci

Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danieljordan-caci @robot-mymove @TevinAdams