Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 22305 int milmove error message has incorrect url for technical helpdesk #14763

Conversation

joeydoyecaci
Copy link
Contributor

@joeydoyecaci joeydoyecaci commented Feb 6, 2025

B-22305

Summary

Corrected error modal support email link

Prereq

Prereqs:
On MoveHome.jsx:102 change the use state default from false to true for const [showErrorAlert, setShowErrorAlert] = useState(true);

How to test

  1. Log into milmovelocal:3000 as any customer with an existing move
  2. Open any of the moves
    3.There should be a modal looking like this:
    Pasted Graphic 1
    4.Hover over the “Technical Help Desk” link, to see the link at the lower corner of the screen, mailto:[email protected]

@joeydoyecaci joeydoyecaci added G-Unit Scrum Team G INTEGRATION Slated for Integration Testing labels Feb 6, 2025
@joeydoyecaci joeydoyecaci self-assigned this Feb 6, 2025
@joeydoyecaci joeydoyecaci requested a review from a team as a code owner February 6, 2025 22:17
joeydoyecaci and others added 4 commits February 6, 2025 17:20
@@ -12,7 +12,7 @@ export const ErrorModal = ({ closeModal, errorMessage, displayHelpDeskLink = tru
<SystemError>
{errorMessage}
{displayHelpDeskLink && (
<a href="mailto:usarmy.scott.sddc.mbx.G6-SRC-M\ilMove-HD@mail.mil">Technical Help Desk</a>
<a href="mailto:=usarmy.scott.sddc.mbx.G6-SRC-MilMove-HD@army.mil">Technical Help Desk</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Joey, it appears you added an equals sign after 'mailto:'. I don't see this in any other part of the code where it's offering a mailto, maybe a mistake?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I leave the '=' in, it puts it in the to line and fails to send.

Copy link
Contributor Author

@joeydoyecaci joeydoyecaci Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah thought it needed one (mistook eslint's error), but yeah looks it didn't after all, just needed to move up a line. Nonetheless just pushed up the change to correct it.

joeydoyecaci and others added 3 commits February 7, 2025 20:30
…r-Technical-Helpdesk' into B-22305-INT-Milmove-Error-message-has-incorrect-URL-for-Technical-Helpdesk
…age-has-incorrect-URL-for-Technical-Helpdesk
@joeydoyecaci joeydoyecaci merged commit 1c65288 into integrationTesting Feb 11, 2025
5 of 6 checks passed
@joeydoyecaci joeydoyecaci deleted the B-22305-INT-Milmove-Error-message-has-incorrect-URL-for-Technical-Helpdesk branch February 11, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
G-Unit Scrum Team G INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

4 participants