B-21962: Create Requested Users Report

[TevinAdams]

Agility ticket

Summary

This PR is introducing exporting to the admin requested users list.

Is there anything you would like reviewers to give additional scrutiny?

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

1. Access the admin app
2. View requested office users list
3. Select some requested office users records using the check boxes on the left
4. Click the export button in the top right corner
5. File should download

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots

[traskowskycaci]

Found something fun - in the case of multiple entries (I tested with two requested office users)

When I selected the checkbox next to both, THEN export - I get the comma separated list for a user that has multiple roles:

But if I just click export without hitting the checkboxes next to each row, I get a row for each role that the user has, instead of a comma separated list:

[danieljordan-caci]

So... I think they will likely want it to be just like the other export capabilities. Right now the user is required to select rows in order to export, but the other pages just have a default export all button. I believe this is wanting that same functionality.

[TevinAdams]

So... I think they will likely want it to be just like the other export capabilities. Right now the user is required to select rows in order to export, but the other pages just have a default export all button. I believe this is wanting that same functionality.

Ill check with Dan on this. Right now how i have it it gives a lot more functionality that put the filters and such in use. If the user wants to export all the just click one checkbox then export. Or if they want to filter then this allows them to expoprt

So... I think they will likely want it to be just like the other export capabilities. Right now the user is required to select rows in order to export, but the other pages just have a default export all button. I believe this is wanting that same functionality.

@danieljordan-caci Bulk export functionality has been removed.

[TevinAdams]

Found something fun - in the case of multiple entries (I tested with two requested office users)

When I selected the checkbox next to both, THEN export - I get the comma separated list for a user that has multiple roles:

But if I just click export without hitting the checkboxes next to each row, I get a row for each role that the user has, instead of a comma separated list:

@traskowskycaci Bulk export functionality has been removed.

[danieljordan-caci]

So... I think they will likely want it to be just like the other export capabilities. Right now the user is required to select rows in order to export, but the other pages just have a default export all button. I believe this is wanting that same functionality.

Ill check with Dan on this. Right now how i have it it gives a lot more functionality that put the filters and such in use. If the user wants to export all the just click one checkbox then export. Or if they want to filter then this allows them to expoprt

So... I think they will likely want it to be just like the other export capabilities. Right now the user is required to select rows in order to export, but the other pages just have a default export all button. I believe this is wanting that same functionality.

Do you plan on checking with Dan on this during standup this morning? I didn't see a message on our DPS Slack about you asking. Just checking back on this.

[TevinAdams]

So... I think they will likely want it to be just like the other export capabilities. Right now the user is required to select rows in order to export, but the other pages just have a default export all button. I believe this is wanting that same functionality.

Ill check with Dan on this. Right now how i have it it gives a lot more functionality that put the filters and such in use. If the user wants to export all the just click one checkbox then export. Or if they want to filter then this allows them to expoprt

So... I think they will likely want it to be just like the other export capabilities. Right now the user is required to select rows in order to export, but the other pages just have a default export all button. I believe this is wanting that same functionality.

Do you plan on checking with Dan on this during standup this morning? I didn't see a message on our DPS Slack about you asking. Just checking back on this.

@danieljordan-caci No I went back and looked at the other implementations and coded it out. Got it working with filters and all so I like it. Bulk functionality is cool but its not consistent with the other exports.

[danieljordan-caci]

From the AC:

Given I am a MilMove Admin in the Requested Office Users queue,
When I select the option to create a report from the Requested Office Users queue, 
Then I will receive a requested report with the following fields:

    • Email
    • First Name
    • Last Name
    • Transportation Office (Real name not UUID)
    • Status
    • "Request On" Date
    • Roles requested (Comma separated field with all roles requested)

When I export this I'm getting:

• email
• firstName
• lastName
• transportationOfficeName
• status
• createdAt
• roles

[TevinAdams]

Member

@danieljordan-caci Yeah i forgot to keep the formatted header logic I had. One moment.

[TevinAdams]

Member

@danieljordan-caci Yeah i forgot to keep the formatted header logic I had. One moment.

@danieljordan-caci fixed

[cameroncaci]

The requested office user export includes the UUID/ID column, which isn't in the AC but the rest of the Excel exports include it, so to keep in line with the rest of the app it should be fine. It'll go to the PO for review

Resolved