B 21934 main #14772
Merged
B 21934 main #14772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n' into B-21934-main
deandreJones
requested review from
danieljordan-caci,
TevinAdams,
cameroncaci and
traskowskycaci
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
Agree with Maria, INT PR 4 has commits the main branch doesn't https://github.com/transcom/mymove/pull/14699/commits |
whoops.. int4 is for the other branch B-21935 |
cameroncaci
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
POA'd, missing commit b4a649f appears to be int-specific (Upstream isn't merged to main yet, it'll break that test when merging so the code fix should eventually make its way in)
|
Hm, actually let me run that one by you @deandreJones. Is b4a649f int-specific? It looks like it got added by INT PR 1 |
pretty sure this is def needed... if I remember correctly 1,000 lbs breaks the test |
danieljordan-caci
approved these changes
Feb 10, 2025
cameroncaci
requested changes
Feb 10, 2025
so the confusion on that.. it was removed when I removed variable completely and only derived it for the UI |
cameroncaci
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INT
INT2
INT 3
int4< correct link