-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main b 22692 #14954
Open
brianmanley-caci
wants to merge
13
commits into
main
Choose a base branch
from
MAIN-B-22692
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Main b 22692 #14954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljordan-caci
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and commits match up!
msaki-caci
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket
INT PR
Summary
Feature E-06260 is for adding the ability for the Prime to send an acknowledgement date for moves and shipments. This story does the DB work to prepare for that capability. We are adding a new
prime_acknowledged_at
column to themoves
andmto_shipments
tables to store that prime acknowledgement value. We are also adding a new function to take in the acknowledgement data sent by the prime, validate it, and update theprime_acknowledged_at
DB values accordingly.Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
One note for testing. The
prime_acknowledged_at
column can only be populated once. For repeated testing make sure to null out the column values, or you'll just get stuck with the initial value you populated.prime_acknowledged_at
column is on themoves
andmto_shipments
tables and the proc is there. You can runSELECT * FROM information_schema.columns WHERE table_name in ('moves', 'mto_shipments') AND column_name = 'prime_acknowledged_at';
, and
SELECT * FROM pg_proc p JOIN pg_namespace n ON p.pronamespace = n.oid WHERE n.nspname = 'public' AND p.proname = 'prime_acknowledge_moves_shipments';
, or you can just look for them in DBeaver like a normal person.
select m.id as move_id, ms.id as shipment_id, m.prime_acknowledged_at as move_prime_acknowledged_at, ms.prime_acknowledged_at as shipment_prime_acknowledged_at from moves m join mto_shipments ms on m.id = ms.move_id;
CALL prime_acknowledge_moves_shipments( '[ { "id": "7c982615-d1e2-44ad-bfbb-b1d22ec29df3", "primeAcknowledgedAt": "2025-12-20T14:15:22Z", "mtoShipments": [ { "id": "d76ae57b-a0da-4dc7-b493-74f11fd6193d", "primeAcknowledgedAt": "2025-12-21T14:15:33Z" } ] }, { "id": "d4d95b22-2d9d-428b-9a11-284455aa87ba", "primeAcknowledgedAt": "2025-12-22T14:16:32Z", "mtoShipments": [ { "id": "acf7b357-5cad-40e2-baa7-dedc1d4cf04c", "primeAcknowledgedAt": "2025-12-23T14:16:44Z" } ] } ]'::jsonb );
select m.id as move_id, ms.id as shipment_id, m.prime_acknowledged_at as move_prime_acknowledged_at, ms.prime_acknowledged_at as shipment_prime_acknowledged_at from moves m join mto_shipments ms on m.id = ms.move_id where m.id in ('7c982615-d1e2-44ad-bfbb-b1d22ec29df3', 'd4d95b22-2d9d-428b-9a11-284455aa87ba') and ms.id in ('d76ae57b-a0da-4dc7-b493-74f11fd6193d', 'acf7b357-5cad-40e2-baa7-dedc1d4cf04c');
Play around with some different scenarios that could break this:
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots