Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 22602 INT - 10.3.0 #14965

Open
wants to merge 8 commits into
base: integrationTesting
Choose a base branch
from
Open

B 22602 INT - 10.3.0 #14965

wants to merge 8 commits into from

Conversation

ajlusk
Copy link
Contributor

@ajlusk ajlusk commented Mar 5, 2025

Agility Ticket B-22602

Previous INT PR for version 10.2.0

Summary

Overrides a sub dependency to use the latest version that patches a vulnerability per PO requirement.

Jsonpath-plus 10.3.0 did not exist when this task was broken down and the parent dependency has not released (to npm) a version that requires/allows 10.3.0.

So golang linter changes as well.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Does the app still run?
  2. Can you still make a commit without the spectral yaml linter failing? The parent library of json-path (spectral) is used for linting in the pre commit checks.
  3. Does yarn.lock contain jsonpath-plus v10.3.0 and nothing earlier?

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

@ajlusk ajlusk requested a review from a team March 5, 2025 20:01
@ajlusk ajlusk self-assigned this Mar 5, 2025
@ajlusk ajlusk marked this pull request as ready for review March 5, 2025 20:04
@ajlusk ajlusk requested review from a team as code owners March 5, 2025 20:04
@ajlusk ajlusk changed the title B 22602 INT - 10.3 B 22602 INT - 10.3.0 Mar 5, 2025
@ajlusk ajlusk added Scrummy Bears Scrum Team H INTEGRATION Slated for Integration Testing labels Mar 5, 2025
@ajlusk ajlusk mentioned this pull request Mar 5, 2025
17 tasks
Copy link
Contributor

@r-mettler r-mettler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No spectral errors and app runs.

Copy link
Contributor

@antgmann antgmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the following location for this value was updated for 10.2.0, does it need to be updated for 10.3.0 as well?
image

@antgmann
Copy link
Contributor

antgmann commented Mar 7, 2025

Ricky believes the above change is required, going to try to make it real quick

@antgmann
Copy link
Contributor

antgmann commented Mar 7, 2025

Attempting to make the changes above causes spectral to fail, so Alex's solution is correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H
Development

Successfully merging this pull request may close these issues.

3 participants