B-22244-INT #14972
Open
B-22244-INT #14972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n iHHG, specifically testing that the change is applied after saving the Review Modal, no need to save on the Shipment Edit page too. Fixed a bug in testharness/make_move.go, the MS service item must be on the Move not the Shipment. Also fixed a typo in the dHHG test.
stevengleason-caci
added
INTEGRATION
stevengleason-caci
requested review from
danieljordan-caci,
traskowskycaci and
a team
| @@ -11073,8 +11073,7 @@ func makeIntlHHGMoveDestAddressRequested( | |||
| factory.BuildMTOServiceItemBasic(appCtx.DB(), []factory.Customization{ | |||
| { | |||
| Model: models.MTOServiceItem{ | |||
| Status: models.MTOServiceItemStatusApproved, | |||
| MTOShipmentID: &shipmentAddressUpdate.Shipment.ID, | |||
| Status: models.MTOServiceItemStatusApproved, | |||
There was a problem hiding this comment.
This was causing a DB error during service item re-calculation. I believe the MS Move Management service item should be linked to only the move, not the shipment. With this change the generated test shipment shows the Move Management service item in the MTO Service Items section instead of the shipment Approved Service Items which now matches shipments I made manually through the UI.
| @@ -644,7 +644,7 @@ test.describe('TOO user', () => { | |||
|
|
|||
| test('approves a delivery address change request for an HHG shipment', async ({ officePage, page }) => { | |||
| test.setTimeout(300000); // This one has been a headache forever. Shoehorn fix to go way above default "slow" timeout | |||
| const shipmentAddressUpdate = await officePage.testHarness.bulidHHGMoveWithAddressChangeRequest(); | |||
| const shipmentAddressUpdate = await officePage.testHarness.buildHHGMoveWithAddressChangeRequest(); | |||
There was a problem hiding this comment.
Fixed a typo I noticed, "bulid" vs "build"
msaki-caci
previously approved these changes
Mar 7, 2025
msaki-caci
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-22244
Summary
Add a test which covers the fix which was made for I-13712
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots