B 22493 int - clear addr fields when toggle to No

[pambecker]

Agility ticket

Summary

When the user has answered a question regarding an address field as "Yes" and has begun filling out address information, when they change their mind and click "No" the address information should be cleared.

How to test

1. Login as a Milmove user, create a new HHG shipment or edit an existing one.
2. Click on the yes to 2nd Pickup Address, fill in all required fields.
3. Click on yes to 3rd Pickup Address, fill in all required fields.
4. Click on yes to 2nd Delivery address, fill in all required fields.
5. Click on yes to 3rd Delivery address, fill in all required fields.
6. Save.
7. Go back into the above shipment and delete Address line 1 from 3rd pickup address.
8. Verify that you get the Required message and that the Save button is disabled.
9. Switch to No I do not have a 3nd pickup address, verify that Save is enabled again.
10. Do this same approach for 2nd pickup (wipe out address line 1, switch to No), and for both 2nd and 3rd Delivery address.
11. Do the same thing on a PPM shipment.
12. Now login as an SC, go into a move and create or edit an HHG and PPM and do it all over again (steps 2-10).

[loganwc]

do we need the green light from @deandreJones on this

[danieljordan-caci]

If it is not on in prod, then it should not be on here

[pambecker]

hmmm....we've had other flags that were turned on right away from creation. I see Boat, Mobile Home, Safety, Queue management, Bulk assignment all as True and none of those are on in prod. I just felt like we had this FF long enough to know any true issues, and I find myself having to change this one constantly lately. Not sure what the rule is but will check

[danieljordan-caci]

Well looks like those changes have been pushed under our noses. I'm just telling you what @deandreJones has said in the past

[deandreJones]

this file should reflect the current state of prod
so that when a dev starts work- they are working with the current state that is prod

you always have the option to use a .envrc.local file to override the values here

[loganwc]

move this into a helper function and call it from all the places you're doing this please

[loganwc]

maybe you could refactor to something like this

const updateAddressToggle = (fieldName, value, fieldKey, blankValue) => {
  setValues((prevValues) => ({
    ...prevValues,
    [fieldName]: value,
    [fieldKey]: value === 'false' ? blankValue : { ...prevValues[fieldKey] },
  }));
};

const handleAddressToggleChange = (e) => {
  const { name, value } = e.target;

  const fieldMap = {
    hasSecondaryPickup: { key: 'secondaryPickup', blankValue: { blankAddress } },
    hasTertiaryPickup: { key: 'tertiaryPickup', blankValue: { blankAddress } },
    hasDeliveryAddress: { key: 'delivery', blankValue: { ...values.delivery, address: newDutyLocationAddress } },
    hasSecondaryDelivery: { key: 'secondaryDelivery', blankValue: { blankAddress } },
    hasTertiaryDelivery: { key: 'tertiaryDelivery', blankValue: { blankAddress } },
  };

  if (fieldMap[name]) {
    updateAddressToggle(name, value, fieldMap[name].key, fieldMap[name].blankValue);
  }
};

[pambecker]

Thanks, I actually meant to go back and figure out something for this, but got held up on tests for so long, forgot about it.