B 22561 add col filtering office users int #14985
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…void any lingering possible issue with storybook
…m/mymove into B-22814-EnvVariableTests
B-22652 MAIN: UB Weight Restriction Email Updates
change to env variables for bypass if needed; unset aws env; fix whitespace; change needs to include now passing/req'd tests; change some images to use harbor proxy vs docker to avoid rate limit
B-22767 MAIN Part 2 - Test Fixes
KonstanceH
added
ByteSize M&Ms
KonstanceH
requested review from
taeJungCaci
and removed request for
amehta-mitre
…61-Add-Col-Filtering-Office-Users-INT
| "search": func(content string) func(*pop.Query) { | ||
| return func(query *pop.Query) { | ||
| firstSearch, lastSearch, emailSearch := fmt.Sprintf("%%%s%%", content), fmt.Sprintf("%%%s%%", content), fmt.Sprintf("%%%s%%", content) | ||
| query.Where("office_users.first_name ILIKE ? AND office_users.status = 'APPROVED' OR office_users.last_name ILIKE ? AND office_users.status = 'APPROVED' OR office_users.email ILIKE ? AND office_users.status = 'APPROVED'", firstSearch, lastSearch, emailSearch) |
There was a problem hiding this comment.
No need to repeat "office_users.status='APPROVED'"... pull it out and group the "OR's" in parenthesis.
i.e. office_users.status = 'APPROVED' AND (office_users.first_name ILIKE ? OR office_users.last_name ILIKE ? OR office_users.email ILIKE ?)
There was a problem hiding this comment.
yea you're right that would look a lot better. And yea I'll add the phone because they're supposed to be able to filter on all the columns except id.
There was a problem hiding this comment.
Took me a minute to find but I was working from my main branch and the phone number is added in integration for admin users but not in main yet. I'm gonna keep it in the filter but just adding this here as a note so I don't forget
B-22657: Ignore Updating updated_at Column when Locking/Unlocking Moves
JamesHawks224
requested changes
Mar 7, 2025
com needs default region changed to region
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-22561
Summary
This PR adds a filter button/functionality to the office users tab on the admin page.
Verification Steps for Reviewers
These are to be checked by a reviewer.
How to test
Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.Backend
Screenshots
Search
With filter
No Results
