Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AP-1800] remove counting rows in checking for resync #1173

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

amofakhar
Copy link
Contributor

@amofakhar amofakhar commented Jul 25, 2024

Problem

it is running count(*) against tables which DBE is not happy about!

Proposed changes

Remove counting row completely since it is not used at all for making decision

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

Details from ticket: AP-1800

PPW:: Remove row count from resync decision process

h2. Context

@amofakhar amofakhar merged commit e913197 into master Jul 25, 2024
14 checks passed
@amofakhar amofakhar deleted the AP-1800_remove_row_count_for_resync_check branch July 25, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants