Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[target-postgres] fix: Map date column to correct postgres type #1188

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

danilofuchs
Copy link
Contributor

@danilofuchs danilofuchs commented Nov 4, 2024

Context

Fixes #1187

Maps a JSON schema column of type string and format date to the DATE type in Postgres

We use this type extensively in our Postgres DB for data such due_date, birth_date, expiration_date, which do not contain any time/timezone info

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Relevant documentation is updated including usage instructions

@louis-pie louis-pie merged commit 4895d9f into transferwise:master Nov 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[target-postgres] Source with format date becomes VARCHAR instead of DATE
2 participants