Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes twice the fall damage is applied #2183

Open
mugg91 opened this issue Nov 24, 2024 · 0 comments · May be fixed by #2185
Open

Sometimes twice the fall damage is applied #2183

mugg91 opened this issue Nov 24, 2024 · 0 comments · May be fixed by #2185
Labels
bug An *objective* unintended feature/mechanic that should be fixed engine change An issue that requires changes to the KAG engine

Comments

@mugg91
Copy link
Contributor

mugg91 commented Nov 24, 2024 •
edited
Loading

Description

On both client and server, I found that onCollision() in FallDamage.as could be run twice on the same tick, with unchanged velocity and old velocity, if getting bounced to the ground onto a corner like in the screenshot below.

The bug happens because of the corner I'm standing on. It does not happen if it's two blocks.

Because of the bug, you can take the same damage twice (1 heart instead of 0.5 hearts).

screen-24-11-24-18-26-20

I'm not sure why it happens.
@mugg91 mugg91 linked a pull request Nov 24, 2024 that will close this issue
Open
@Vam-Jam Vam-Jam added bug An *objective* unintended feature/mechanic that should be fixed engine change An issue that requires changes to the KAG engine labels Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An *objective* unintended feature/mechanic that should be fixed engine change An issue that requires changes to the KAG engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fixed] You no longer can take fall damage twice on the same tick mugg91/kag-base
2 participants
@mugg91 @Vam-Jam