Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new] Start of voting to kick logging #2134

Merged
merged 3 commits into from
Nov 28, 2024
Merged

[new] Start of voting to kick logging #2134

merged 3 commits into from
Nov 28, 2024

Conversation

Vam-Jam
Copy link
Member

@Vam-Jam Vam-Jam commented Oct 8, 2024 •
edited
Loading

Add's voting to kick logging that gets sent to bsion.

What the message looks like:

Known issues:

  • Admin forcing to cancel does not call Pass() whatsoever, but forcing to pass does

@Vam-Jam
[dev] Start of voting to kick logging
f271fb3 
Requires a new engine binding to expose the current server's ip (if
possible?)
@Vam-Jam Vam-Jam added the testing needed An issue needs to undergo a testing sessions to verify the change or check for newly introduced bugs label Oct 8, 2024
@Vam-Jam Vam-Jam marked this pull request as draft October 8, 2024 13:30
@Vam-Jam
Copy link
Member Author

Vam-Jam commented Oct 10, 2024

Added a new engine bind getNet().sv_current_ip

@Vam-Jam Vam-Jam marked this pull request as ready for review October 10, 2024 10:13
@Vam-Jam Vam-Jam changed the title [WIP] [new] Start of voting to kick logging [new] Start of voting to kick logging Oct 10, 2024
@Vam-Jam
Copy link
Member Author

Vam-Jam commented Oct 10, 2024

PR also moves report code to the new engine bind, instead of having the client send joined_ip every report.

@Vam-Jam Vam-Jam added this to the Next Patch milestone Oct 10, 2024
@asumagic asumagic merged commit 8511ff6 into transhumandesign:master Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asumagic asumagic asumagic approved these changes

Assignees
No one assigned
Labels
testing needed An issue needs to undergo a testing sessions to verify the change or check for newly introduced bugs
Projects
None yet
Milestone
Next Patch
Development

Successfully merging this pull request may close these issues.
2 participants
@Vam-Jam @asumagic