Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[changed] Trampoline interaction with Saw & Arrows #2163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mugg91
Copy link
Contributor

@mugg91 mugg91 commented Nov 17, 2024

Status

  • READY: this PR is (to the best of your knowledge) ready to be incorporated into the game.

Description

[changed] Trampoline isn't destroyed by Saw unless if it falls into it from above
[changed] Own team arrows will not get eaten by Saw except if they are shot at it from above

Fixes #2161
Fixes #2162

This PR aims to open up more strategies by allowing same team Arrows to be shot through Saw from the side or below, and by allowing Saw to bounce on Trampoline without destroying the Trampoline. Enemy team arrows will still collide with and deal damage to Saw if shot from any side.

Unlike suggested in the issues linked above, I think it is ok to have Saw not destroy Trampoline regardless of the team.

Tested in offline and online, works as envisioned.

This PR is based on the current Build 4762.

Comparison

Before


After


@Vam-Jam Vam-Jam self-assigned this Nov 18, 2024
Copy link
Member

@Vam-Jam Vam-Jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in dedicated, seems to be fine.

@Vam-Jam Vam-Jam added the ready A pull request that functions correctly and is ready for testing label Nov 22, 2024
@mehwaffle10
Copy link

To be clear, taking cover from archers behind enemy saws is a known and used strategy that this would be a nerf to. This also slightly increases the incentive for players to take team saws to use as one way shields, which some can be viewed as griefing and should not be encouraged without proper caution. On the flip side, this is a buff to archers who can get their hand on an enemy saw in their base against other archers but a nerf until they can actually pick it up and convert it.

@Vam-Jam Vam-Jam added the discussion An controversial/debatable issue requiring discussion by the community before implementation label Nov 23, 2024
@mugg91
Copy link
Contributor Author

mugg91 commented Nov 23, 2024

@mehwaffle10

To be clear, taking cover from archers behind enemy saws is a known and used strategy that this would be a nerf to.

If taking cover from archers shooting from the bottom, then yes. This buffs Saw for the team it belongs to.

Now that you mention it though, "Saw shield" sounds lame.
We don't want archers hiding behind a Saw at the frontline, do we?
Even when Saw can possibly get destroyed quickly and isn't so easy to replace that it will get spammed at the frontline.
Should I remove that change from this PR?

@Vam-Jam Vam-Jam added the CTF PR that is focused towards CTF label Nov 23, 2024
@mehwaffle10
Copy link

Less so from the bottom, more so running past a saw in a tree farm in the enemy base to take cover from archers. I would think it would be more so griefing than spam, since saws are expensive enough that the other classes can't readily acquire them without taking dropped materials

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CTF PR that is focused towards CTF discussion An controversial/debatable issue requiring discussion by the community before implementation ready A pull request that functions correctly and is ready for testing
Projects
None yet
3 participants